From d741499926a75eb4454aa7dcf4cca96d790718aa Mon Sep 17 00:00:00 2001 From: Doug Hellmann Date: Mon, 9 May 2016 09:36:07 -0400 Subject: [PATCH] update the review instructions for new lib releases We updated the release process to ask folks to submit constraint updates, and this change updates the review instructions here to tell new reviewers to allow them. Change-Id: I5b8a4d3922794b05d34dc8355de97ee7dd2bf42a Signed-off-by: Doug Hellmann --- README.rst | 15 +++++++++++---- 1 file changed, 11 insertions(+), 4 deletions(-) diff --git a/README.rst b/README.rst index 36d44d047a..8f260c5854 100644 --- a/README.rst +++ b/README.rst @@ -354,10 +354,17 @@ If the change was proposed by the OpenStack CI bot, then if the change has passed CI, only one reviewer is needed and they should +2 +A without thinking about things. -If the change was not proposed by the OpenStack CI bot, and does not include a -``global-requirements.txt`` change, then it should be rejected: the CI bot -will generate an appropriate change itself. Ask in #openstack-infra if the -bot needs to be run more quickly. +If the change was not proposed by the OpenStack CI bot, and only +changes the ``upper-constraints.txt`` entry for a new library release, +then the change should be approved if it passes the tests. See the +README.rst in openstack/releases for more details of the release +process. + +If the change was not proposed by the OpenStack CI bot, and is not +related to releasing one of our libraries, and does not include a +``global-requirements.txt`` change, then it should be rejected: the CI +bot will generate an appropriate change itself. Ask in +#openstack-infra if the bot needs to be run more quickly. Otherwise the change may be the result of recalculating the constraints which changed when a ``global-requirements.txt`` change is proposed. In this case, ignore