From aee6e953804da859ecf55e16c6a6cf5ac7571e6b Mon Sep 17 00:00:00 2001 From: Nguyen Van Trung Date: Wed, 16 May 2018 09:51:18 +0700 Subject: [PATCH] Allow Pygments in openstack/requirements Projects that want to enable a comprehensive doc8 check of code, including D000, need Pygmnets to be installable. It's an option library used by docutils so we need to track it here. While this isn't really a linter, neither is it really required at runtime for the projects using it so it's added to the blacklist Is the library actively maintained? Yes - https://bitbucket.org/birkenfeld/pygments-main Is the library good code? Yes - It is the defacto syntax highlighting code in Python Is the library python 3 compatible? Yes Is the library license compatible? Yes - BSD Is the library already packaged in the distros we target (Ubuntu latest / Fedora latest)? Yes Is the function of this library already covered by other libraries in global-requirements.txt? No Is the library required for OpenStack project or related dev or infrastructure setup? (Answer to this should be Yes, of course) Which? Yes - for doc8 checking where there is code snippets. It is also a transient dependancy of sphinx - https://github.com/sphinx-doc/sphinx/blob/master/setup.py#L21 Change-Id: I643c7632a02c87820c9c51f03fa34f0764384783 Close-bug: #1771479 --- blacklist.txt | 1 + global-requirements.txt | 1 + lower-constraints.txt | 1 - upper-constraints.txt | 1 - 4 files changed, 2 insertions(+), 2 deletions(-) diff --git a/blacklist.txt b/blacklist.txt index 3a7e9606a8..763199d653 100644 --- a/blacklist.txt +++ b/blacklist.txt @@ -12,6 +12,7 @@ pep8 pyflakes pycodestyle pylint +Pygments # Temporarily until tools/tox_install.sh is updated everywhere horizon diff --git a/global-requirements.txt b/global-requirements.txt index 5cab68befb..915c2b846e 100644 --- a/global-requirements.txt +++ b/global-requirements.txt @@ -380,6 +380,7 @@ demjson # GLGPLv3+ docker # Apache-2.0 django-nose # BSD doc8 # Apache-2.0 +Pygments # BSD license fixtures # Apache-2.0/BSD freezegun # Apache-2.0 gabbi # Apache-2.0 diff --git a/lower-constraints.txt b/lower-constraints.txt index 7dcebcd82b..e261c43ed0 100644 --- a/lower-constraints.txt +++ b/lower-constraints.txt @@ -188,7 +188,6 @@ python-novaclient===9.1.0 bcrypt===3.1.3 os-client-config===1.28.0 XStatic-Angular-Gettext===2.3.8.0 -Pygments===2.2.0 XStatic-Hogan===2.0.0.2 XStatic-objectpath===1.2.1.0 python-manilaclient===1.16.0 diff --git a/upper-constraints.txt b/upper-constraints.txt index 5b1910af31..4529bce681 100644 --- a/upper-constraints.txt +++ b/upper-constraints.txt @@ -184,7 +184,6 @@ python-novaclient===10.2.0 bcrypt===3.1.4 os-client-config===1.31.1 XStatic-Angular-Gettext===2.3.8.0 -Pygments===2.2.0 XStatic-Hogan===2.0.0.2 XStatic-objectpath===1.2.1.0 python-manilaclient===1.22.0