From 3c16505fce4953ed72a64c25391082c1650f4ead Mon Sep 17 00:00:00 2001 From: Russell Bryant Date: Fri, 28 Jun 2013 13:20:16 -0400 Subject: [PATCH] Use a better method to only check for human reviews. --- openreviews.py | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/openreviews.py b/openreviews.py index a69301c..fb67199 100755 --- a/openreviews.py +++ b/openreviews.py @@ -199,10 +199,7 @@ def find_oldest_no_nack(change): for patch in reversed(change['patchSets']): nacked = False for review in patch.get('approvals', []): - if review['by'].get('username') == 'jenkins': - # Only consider nacks from people - continue - if review['type'] not in ('CRVW', 'VRIF'): + if review['type'] != 'CRVW': continue if review['value'] in ('-1', '-2'): nacked = True