openstack/shade
Code Issues Proposed changes

Improve test coverage: network delete API

Browse Source 
Add missing unit tests for delete_network() API method.

Change-Id: I75ab31ddeb731d192a0266712bfb95c5f21c8acb
This commit is contained in:
David Shrewsbury 2015-12-08 14:32:54 -05:00
parent d7e616780b
commit 4c8cfe4b18
1 changed files with 28 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

28
shade/tests/unit/test_network.py
View File

@ -11,6 +11,7 @@
# limitations under the License. # limitations under the License.
import mock import mock
import testtools
import shade import shade
from shade.tests.unit import base from shade.tests.unit import base
@ -48,3 +49,30 @@ class TestNetwork(base.TestCase):
} }
) )
) )
@mock.patch.object(shade.OpenStackCloud, 'get_network')
@mock.patch.object(shade.OpenStackCloud, 'neutron_client')
def test_delete_network(self, mock_neutron, mock_get):
mock_get.return_value = dict(id='net-id', name='test-net')
self.assertTrue(self.cloud.delete_network('test-net'))
mock_get.assert_called_once_with('test-net')
mock_neutron.delete_network.assert_called_once_with(network='net-id')
@mock.patch.object(shade.OpenStackCloud, 'get_network')
def test_delete_network_not_found(self, mock_get):
mock_get.return_value = None
self.assertFalse(self.cloud.delete_network('test-net'))
mock_get.assert_called_once_with('test-net')
@mock.patch.object(shade.OpenStackCloud, 'get_network')
@mock.patch.object(shade.OpenStackCloud, 'neutron_client')
def test_delete_network_exception(self, mock_neutron, mock_get):
mock_get.return_value = dict(id='net-id', name='test-net')
mock_neutron.delete_network.side_effect = Exception()
with testtools.ExpectedException(
shade.OpenStackCloudException,
"Error deleting network test-net"
):
self.cloud.delete_network('test-net')
mock_get.assert_called_once_with('test-net')
mock_neutron.delete_network.assert_called_once_with(network='net-id')