openstack/storlets
Code Issues Proposed changes

Use built-in subprocess.DEVNULL

Browse Source 
... instead of creating a file object.

Change-Id: I6f61369f1770f8223544ec5040deeded7640b81b
This commit is contained in:
Takashi Kajinami 2024-02-10 23:21:15 +09:00
parent 40031d0420
commit 876b695219
1 changed files with 3 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
storlets/agent/daemon_factory/server.py
View File

@ -130,15 +130,13 @@ class StorletDaemonFactory(SBusServer):
self.logger.debug('Starting subprocess: pargs:{0} env:{1}'
.format(str_pargs, env))
# TODO(takashi): We had better use contextmanager
# TODO(takashi): Where is this closed?
try:
dn = open(os.devnull, 'wb')
daemon_p = subprocess.Popen(
pargs, stdout=dn, stderr=subprocess.PIPE,
pargs, stdout=subprocess.DEVNULL, stderr=subprocess.PIPE,
close_fds=True, shell=False, env=env)
logger_p = subprocess.Popen(
'logger', stdin=daemon_p.stderr, stdout=dn, stderr=dn,
'logger', stdin=daemon_p.stderr,
stdout=subprocess.DEVNULL, stderr=subprocess.DEVNULL,
close_fds=True, shell=False)
except OSError:
self.logger.exception('Unable to start subprocess')