openstack/storlets
Code Issues Proposed changes

Remove unnecessory -it from docker run command

Browse Source 
We expect that storlets docker containers run in background,
so We don't need -i and -t to start them.
This patch removes these unnecessory options, and also fixes
some outdated comments in restart_docker_container script.

Change-Id: I1f3d207a75767811e8c22a114b7f4c6edfccb1dd
This commit is contained in:
Takashi Kajinami 2019-11-15 13:14:37 +09:00
parent f0b74e1a76
commit e31497dd19
1 changed files with 14 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

19
scripts/restart_docker_container.c
View File

@ -24,11 +24,20 @@
/*
* Stop and Run a docker container using:
* docker stop <container name>
* docker run --name <container name> -d -v /dev/log:/dev/log -v <mount dir 1> -v <mount dir 2> -i -t <image> --net='none'
* docker run --net=none --name <container name> -d -v /dev/log:/dev/log \
* -v <mount dir 1> -v <mount dir 2> -v <mount dir 3> -v <mount dir 4> \
* <image name>
*
* <container name> - The name of the container to stop / to start
* <image name> - the name of the image from which to start the container
* <mount dir 1> - The directory where the named pipes are placed. Typically mounted to /mnt/channels in the container
* <mount dir 2> - The directory where the storlets are placed. Typically mounted to /home/swift in the container
* <image name> - the name of the image from which to start the container
* <mount dir 1> - The directory where the named pipes are placed.
* Typically mounted to /mnt/channels in the container
* <mount dir 2> - The directory where the storlets are placed.
* Typically mounted to /home/swift in the container
* <mount dir 3> - The directory where storlets library are placed.
* Typically mounted to /usr/local/lib/storlets
* <mount dir 4> - The directory where storlets executables are placed.
* Typically mounted to /usr/local/libexec/storlets
*/
int main(int argc, char **argv) {
@ -63,7 +72,7 @@ int main(int argc, char **argv) {
ret = system(command);
sprintf(command,
"/usr/bin/docker run --net=none --name %s -d -v /dev/log:/dev/log -v %s -v %s -v %s -v %s -i -t %s",
"/usr/bin/docker run --net=none --name %s -d -v /dev/log:/dev/log -v %s -v %s -v %s -v %s %s",
container_name,
mount_dir1,
mount_dir2,