From 5210d9e230857d7ad92ab91a0029ea479e2237ed Mon Sep 17 00:00:00 2001 From: Guillaume Boutry Date: Wed, 21 Aug 2024 09:10:48 +0200 Subject: [PATCH] [ops-sunbeam] ingress_changed can fail when the relation is gone Catch AttributeError/KeyError as a stop gap to prevent _ingress_changed to fail on relation-broken. Change-Id: Ib29af68bf498c6adb84064f871dc678b783213c3 Signed-off-by: Guillaume Boutry --- ops-sunbeam/ops_sunbeam/charm.py | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/ops-sunbeam/ops_sunbeam/charm.py b/ops-sunbeam/ops_sunbeam/charm.py index 3478f616..269f9bad 100644 --- a/ops-sunbeam/ops_sunbeam/charm.py +++ b/ops-sunbeam/ops_sunbeam/charm.py @@ -851,9 +851,12 @@ class OSBaseOperatorAPICharm(OSBaseOperatorCharmK8S): logger.debug("Received an ingress_changed event") if hasattr(self, "id_svc"): logger.debug( - "Updating service endpoints after ingress " "relation changed." + "Updating service endpoints after ingress relation changed." ) - self.id_svc.update_service_endpoints(self.service_endpoints) + try: + self.id_svc.update_service_endpoints(self.service_endpoints) + except (AttributeError, KeyError): + pass self.configure_charm(event)