Files
sunbeam-charms/charms/manila-cephfs-k8s/tests/unit/test_charm.py
Claudiu Belu 9cdb254685 fix: inconsistent ceph-nfs relation mon_hosts key
The CephNfsProvides set the mon_hosts key, while the CephNfsRequires
accesses mon-hosts.

xref: https://github.com/canonical/charm-microceph/pull/200

Change-Id: Ib00947ed47fac6c82b25eea2dfe37b19649a716b
Signed-off-by: Claudiu Belu <cbelu@cloudbasesolutions.com>
2025-09-12 08:02:50 +00:00

212 lines
7.1 KiB
Python

#!/usr/bin/env python3
# Copyright 2025 Canonical Ltd.
#
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
# You may obtain a copy of the License at
#
# http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing, software
# distributed under the License is distributed on an "AS IS" BASIS,
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
# See the License for the specific language governing permissions and
# limitations under the License.
"""Unit tests for the Manila Share (Cephfs) K8s Operator charm."""
import charm
import charms.ceph_nfs_client.v0.ceph_nfs_client as ceph_nfs_client
import charms.manila_k8s.v0.manila as manila_k8s
import ops_sunbeam.test_utils as test_utils
from ops import (
model,
pebble,
)
class _ManilaCephfsCharm(charm.ManilaShareCephfsCharm):
"""Test implementation of Manila Share (Cephfs) Operator charm."""
def __init__(self, framework):
self.seen_events = []
self.render_calls = []
super().__init__(framework)
def _log_event(self, event):
self.seen_events.append(type(event).__name__)
def renderer(self, containers, container_configs, template_dir, adapters):
"""Intercept and record all calls to render config files."""
self.render_calls.append(
(containers, container_configs, template_dir, adapters)
)
def configure_charm(self, event):
"""Intercept and record full charm configuration events."""
super().configure_charm(event)
self._log_event(event)
class TestManilaCephfsCharm(test_utils.CharmTestCase):
"""Unit tests for Manila Share (Cephfs) Operator charm."""
PATCHES = []
def setUp(self):
"""Setup test fixtures for test."""
super().setUp(charm, self.PATCHES)
self.harness = test_utils.get_harness(
_ManilaCephfsCharm, container_calls=self.container_calls
)
# clean up events that were dynamically defined,
# otherwise we get issues because they'll be redefined,
# which is not allowed.
from charms.data_platform_libs.v0.data_interfaces import (
DatabaseRequiresEvents,
)
for attr in (
"database_database_created",
"database_endpoints_changed",
"database_read_only_endpoints_changed",
):
try:
delattr(DatabaseRequiresEvents, attr)
except AttributeError:
pass
self.addCleanup(self.harness.cleanup)
self.harness.begin()
def add_ceph_nfs_client_relation(self) -> None:
"""Add the ceph-nfs relation and unit data."""
app_data = {
"client": "client.foo",
ceph_nfs_client.CLUSTER_ID: "lish",
"fsid": "fake-fsid",
"keyring": "keys-do-not-ring",
ceph_nfs_client.MON_HOSTS: '["mony"]',
"volume": "voly",
}
return self.harness.add_relation(
charm.CEPH_NFS_RELATION_NAME,
"microceph",
app_data=app_data,
)
def _file_exists(self, container, path) -> bool:
client = self.harness.charm.unit.get_container(container)._pebble # type: ignore
try:
files = client.list_files(path, itself=True)
except pebble.APIError as ex:
if ex.code == 404:
return False
# Reraise if there's any other error than Not Found.
raise
return len(files) == 1 and files[0].path == path
def _check_file_contents(self, container, path, strings):
client = self.harness.charm.unit.get_container(container)._pebble # type: ignore
with client.pull(path) as infile:
received_data = infile.read()
for string in strings:
self.assertIn(string, received_data)
def test_pebble_ready_handler(self):
"""Test pebble ready event handling."""
self.assertEqual(self.harness.charm.seen_events, [])
self.harness.container_pebble_ready("manila-share")
self.assertEqual(self.harness.charm.seen_events, ["PebbleReadyEvent"])
def test_all_relations(self):
"""Test all integrations for operator."""
self.harness.set_leader()
test_utils.set_all_pebbles_ready(self.harness)
# this adds all the default/common relations
test_utils.add_all_relations(self.harness)
# ceph-nfs is a required relation.
ceph_nfs_status = self.harness.charm.ceph_nfs.status
self.assertIsInstance(ceph_nfs_status.status, model.BlockedStatus)
# The files should not exist if the relation is not present.
self.assertFalse(
self._file_exists("manila-share", "/etc/ceph/ceph.conf")
)
self.assertFalse(
self._file_exists("manila-share", "/etc/ceph/manila.keyring")
)
self.assertFalse(
self._file_exists("manila-share", "/etc/manila/manila.conf")
)
self.harness.add_relation("manila", "manila")
# The ceph-nfs relation is not set yet, so there should not be any
# data here.
manila_rel = self.harness.model.get_relation("manila")
manila_rel_data = manila_rel.data[self.harness.model.app]
self.assertEqual({}, manila_rel_data)
ceph_rel_id = self.add_ceph_nfs_client_relation()
# Now that the relation is added, we should have the ceph-related
# options set.
ceph_conf_strings = [
"[global]",
"mon host = mony",
"[client]",
"keyring = /etc/ceph/manila.keyring",
]
self._check_file_contents(
"manila-share",
"/etc/ceph/ceph.conf",
ceph_conf_strings,
)
keyring_strings = ["[client.foo]", "key = keys-do-not-ring"]
self._check_file_contents(
"manila-share",
"/etc/ceph/manila.keyring",
keyring_strings,
)
manila_strings = [
"enabled_share_backends = cephnfs",
"[cephnfs]",
"share_backend_name = CEPHNFS",
"cephfs_auth_id = foo",
"cephfs_cluster_name = lish",
"cephfs_nfs_cluster_id = lish",
"cephfs_filesystem_name = voly",
]
self._check_file_contents(
"manila-share",
"/etc/manila/manila.conf",
manila_strings,
)
# After the ceph-nfs relation has been established, the charm should
# set the manila relation data.
self.assertEqual(
charm.SHARE_PROTOCOL_NFS,
manila_rel_data.get(manila_k8s.SHARE_PROTOCOL),
)
# Remove the ceph-nfs relation. The relation handler should be in a
# BlockedStatus.
self.harness.remove_relation(ceph_rel_id)
self.assertIsInstance(ceph_nfs_status.status, model.BlockedStatus)
# Because the ceph-nfs relation has been removed, the manila relation
# data should be cleared.
self.assertEqual({}, manila_rel_data)