openstack/swift
Code Issues Proposed changes

Merge "Clean up comment about 404s leaking out during COPYs"

Browse Source
This commit is contained in:
Zuul 2018-09-26 14:39:10 +00:00 committed by Gerrit Code Review
commit c26141c209
1 changed files with 43 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

46
test/functional/tests.py
View File

@ -1781,9 +1781,7 @@ class TestFile(Base):
(prefix, (prefix,
Utils.create_name(), Utils.create_name(),
source_filename)}) source_filename)})
# looks like cached responses leak "not found" self.assert_status(403)
# to un-authorized users, not going to fix it now, but...
self.assert_status([403, 404])
# invalid source object # invalid source object
file_item = self.env.container.file(Utils.create_name()) file_item = self.env.container.file(Utils.create_name())
@ -1806,6 +1804,48 @@ class TestFile(Base):
source_filename)}) source_filename)})
self.assert_status(404) self.assert_status(404)
def testCopyFromAccountHeader403s(self):
acct = self.env.conn2.account_name
src_cont = self.env.account2.container(Utils.create_name())
self.assertTrue(src_cont.create()) # Primary user has no access
source_filename = Utils.create_name()
file_item = src_cont.file(source_filename)
file_item.write_random()
dest_cont = self.env.account.container(Utils.create_name())
self.assertTrue(dest_cont.create())
for prefix in ('', '/'):
# invalid source container
file_item = dest_cont.file(Utils.create_name())
self.assertRaises(ResponseError, file_item.write,
hdrs={'X-Copy-From-Account': acct,
'X-Copy-From': '%s%s/%s' %
(prefix,
Utils.create_name(),
source_filename)})
self.assert_status(403)
# invalid source object
file_item = self.env.container.file(Utils.create_name())
self.assertRaises(ResponseError, file_item.write,
hdrs={'X-Copy-From-Account': acct,
'X-Copy-From': '%s%s/%s' %
(prefix,
src_cont,
Utils.create_name())})
self.assert_status(403)
# invalid destination container
dest_cont = self.env.account.container(Utils.create_name())
file_item = dest_cont.file(Utils.create_name())
self.assertRaises(ResponseError, file_item.write,
hdrs={'X-Copy-From-Account': acct,
'X-Copy-From': '%s%s/%s' %
(prefix,
src_cont,
source_filename)})
self.assert_status(403)
def testNameLimit(self): def testNameLimit(self):
limit = load_constraint('max_object_name_length') limit = load_constraint('max_object_name_length')