0a26bb20b1
As it happens, diskfile.read_metadata() and diskfile.write_metadata()
can take either an open file or a filename as their first arguments
(since xattr.[get|set]xattr() can), so we can clean up a couple places
where we were opening a file just to call read_metadata() or
write_metadata() on it. This results in 2 fewer system calls.
Example strace output:
/* read_metadata(filename) */
getxattr("/mnt/sdb1/1/node/sdb1/afile", "user.some.key", 0x0, 0) = 10
getxattr("/mnt/sdb1/1/node/sdb1/afile", "user.some.key", "some-value", 10) = 10
/* fp = open(filename); read_metadata(fp) */
open("/mnt/sdb1/1/node/sdb1/afile", O_RDONLY) = 4
fstat(4, {st_mode=S_IFREG|0664, st_size=0, ...}) = 0
fgetxattr(4, "user.some.key", 0x0, 0) = 10
fgetxattr(4, "user.some.key", "some-value", 10) = 10
Change-Id: I321d8663b9e9e47b8f3ee6c21a1b65b408bb80e6
171 lines
6.8 KiB
Python
Executable File
171 lines
6.8 KiB
Python
Executable File
#!/usr/bin/python -u
|
|
# Copyright (c) 2010-2012 OpenStack Foundation
|
|
#
|
|
# Licensed under the Apache License, Version 2.0 (the "License");
|
|
# you may not use this file except in compliance with the License.
|
|
# You may obtain a copy of the License at
|
|
#
|
|
# http://www.apache.org/licenses/LICENSE-2.0
|
|
#
|
|
# Unless required by applicable law or agreed to in writing, software
|
|
# distributed under the License is distributed on an "AS IS" BASIS,
|
|
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or
|
|
# implied.
|
|
# See the License for the specific language governing permissions and
|
|
# limitations under the License.
|
|
|
|
from os import listdir, unlink
|
|
from os.path import join as path_join
|
|
from unittest import main, TestCase
|
|
from uuid import uuid4
|
|
|
|
from swiftclient import client
|
|
|
|
from swift.common import direct_client
|
|
from swift.common.utils import hash_path, readconf
|
|
from swift.obj.diskfile import write_metadata, read_metadata
|
|
from test.probe.common import kill_servers, reset_environment
|
|
|
|
|
|
def get_data_file_path(obj_dir):
|
|
files = sorted(listdir(obj_dir), reverse=True)
|
|
for filename in files:
|
|
return path_join(obj_dir, filename)
|
|
|
|
|
|
class TestObjectFailures(TestCase):
|
|
|
|
def setUp(self):
|
|
(self.pids, self.port2server, self.account_ring, self.container_ring,
|
|
self.object_ring, self.url, self.token,
|
|
self.account, self.configs) = reset_environment()
|
|
|
|
def tearDown(self):
|
|
kill_servers(self.port2server, self.pids)
|
|
|
|
def _setup_data_file(self, container, obj, data):
|
|
client.put_container(self.url, self.token, container)
|
|
client.put_object(self.url, self.token, container, obj, data)
|
|
odata = client.get_object(self.url, self.token, container, obj)[-1]
|
|
self.assertEquals(odata, data)
|
|
opart, onodes = self.object_ring.get_nodes(
|
|
self.account, container, obj)
|
|
onode = onodes[0]
|
|
node_id = (onode['port'] - 6000) / 10
|
|
device = onode['device']
|
|
hash_str = hash_path(self.account, container, obj)
|
|
obj_server_conf = readconf(self.configs['object'] % node_id)
|
|
devices = obj_server_conf['app:object-server']['devices']
|
|
obj_dir = '%s/%s/objects/%s/%s/%s/' % (devices,
|
|
device, opart,
|
|
hash_str[-3:], hash_str)
|
|
data_file = get_data_file_path(obj_dir)
|
|
return onode, opart, data_file
|
|
|
|
def run_quarantine(self):
|
|
container = 'container-%s' % uuid4()
|
|
obj = 'object-%s' % uuid4()
|
|
onode, opart, data_file = self._setup_data_file(container, obj,
|
|
'VERIFY')
|
|
metadata = read_metadata(data_file)
|
|
metadata['ETag'] = 'badetag'
|
|
write_metadata(data_file, metadata)
|
|
|
|
odata = direct_client.direct_get_object(
|
|
onode, opart, self.account, container, obj)[-1]
|
|
self.assertEquals(odata, 'VERIFY')
|
|
try:
|
|
direct_client.direct_get_object(onode, opart, self.account,
|
|
container, obj)
|
|
raise Exception("Did not quarantine object")
|
|
except client.ClientException as err:
|
|
self.assertEquals(err.http_status, 404)
|
|
|
|
def run_quarantine_range_etag(self):
|
|
container = 'container-range-%s' % uuid4()
|
|
obj = 'object-range-%s' % uuid4()
|
|
onode, opart, data_file = self._setup_data_file(container, obj,
|
|
'RANGE')
|
|
|
|
metadata = read_metadata(data_file)
|
|
metadata['ETag'] = 'badetag'
|
|
write_metadata(data_file, metadata)
|
|
for header, result in [({'Range': 'bytes=0-2'}, 'RAN'),
|
|
({'Range': 'bytes=1-11'}, 'ANGE'),
|
|
({'Range': 'bytes=0-11'}, 'RANGE')]:
|
|
odata = direct_client.direct_get_object(
|
|
onode, opart, self.account, container, obj, headers=header)[-1]
|
|
self.assertEquals(odata, result)
|
|
|
|
try:
|
|
direct_client.direct_get_object(onode, opart, self.account,
|
|
container, obj)
|
|
raise Exception("Did not quarantine object")
|
|
except client.ClientException as err:
|
|
self.assertEquals(err.http_status, 404)
|
|
|
|
def run_quarantine_zero_byte_get(self):
|
|
container = 'container-zbyte-%s' % uuid4()
|
|
obj = 'object-zbyte-%s' % uuid4()
|
|
onode, opart, data_file = self._setup_data_file(container, obj, 'DATA')
|
|
metadata = read_metadata(data_file)
|
|
unlink(data_file)
|
|
|
|
with open(data_file, 'w') as fpointer:
|
|
write_metadata(fpointer, metadata)
|
|
try:
|
|
direct_client.direct_get_object(onode, opart, self.account,
|
|
container, obj, conn_timeout=1,
|
|
response_timeout=1)
|
|
raise Exception("Did not quarantine object")
|
|
except client.ClientException as err:
|
|
self.assertEquals(err.http_status, 404)
|
|
|
|
def run_quarantine_zero_byte_head(self):
|
|
container = 'container-zbyte-%s' % uuid4()
|
|
obj = 'object-zbyte-%s' % uuid4()
|
|
onode, opart, data_file = self._setup_data_file(container, obj, 'DATA')
|
|
metadata = read_metadata(data_file)
|
|
unlink(data_file)
|
|
|
|
with open(data_file, 'w') as fpointer:
|
|
write_metadata(fpointer, metadata)
|
|
try:
|
|
direct_client.direct_head_object(onode, opart, self.account,
|
|
container, obj, conn_timeout=1,
|
|
response_timeout=1)
|
|
raise Exception("Did not quarantine object")
|
|
except client.ClientException as err:
|
|
self.assertEquals(err.http_status, 404)
|
|
|
|
def run_quarantine_zero_byte_post(self):
|
|
container = 'container-zbyte-%s' % uuid4()
|
|
obj = 'object-zbyte-%s' % uuid4()
|
|
onode, opart, data_file = self._setup_data_file(container, obj, 'DATA')
|
|
metadata = read_metadata(data_file)
|
|
unlink(data_file)
|
|
|
|
with open(data_file, 'w') as fpointer:
|
|
write_metadata(fpointer, metadata)
|
|
try:
|
|
direct_client.direct_post_object(
|
|
onode, opart, self.account,
|
|
container, obj,
|
|
{'X-Object-Meta-1': 'One', 'X-Object-Meta-Two': 'Two'},
|
|
conn_timeout=1,
|
|
response_timeout=1)
|
|
raise Exception("Did not quarantine object")
|
|
except client.ClientException as err:
|
|
self.assertEquals(err.http_status, 404)
|
|
|
|
def test_runner(self):
|
|
self.run_quarantine()
|
|
self.run_quarantine_range_etag()
|
|
self.run_quarantine_zero_byte_get()
|
|
self.run_quarantine_zero_byte_head()
|
|
self.run_quarantine_zero_byte_post()
|
|
|
|
|
|
if __name__ == '__main__':
|
|
main()
|