openstack/swift
Code Issues Proposed changes
354a86a80e
swift/test/unit/obj
History
Alistair Coles 4bb78de611 Fix os.link exceptions in diskfile.relink_paths 
Previously, when a diskfile was relinked in a new partition, the
diskfile.relink_paths() would test for the existence of the link
before attempting to create it. This 'test then set' might race with
another process creating the same diskfile (e.g. a concurrent PUT
which created the very same object in an old partition that the
relinker is also relinking). The race might lead to an attempt to
create a link that already exists (despite the pre-check) and an
EEXIST exception being raised.

This patch modifies relink_paths to tolerate EEXIST exceptions but
only if the existing file is a link to the target file. Otherwise the
EEXIST exception is still raised.

The 'check_existing' argument for relink_paths is removed since it is
no longer relevant.

relink_paths() might also raise an ENOENT exception if, while a
diskfile is being relinked in the 'new' partition dir, another process
PUTs a newer version of the same object and as a result cleans up the
older diskfile in the 'old' partition before the first process has
called os.link().

This patch modifies relink_paths() to tolerate ENOENT exceptions from
os.link() but only if the target path (i.e. the file in the 'old'
partition) no longer exists. Otherwise the ENOENT will still be
raised.

This patch also modifies relink_paths() to return a boolean indicating
if the hard link was created by the call to the method (True) or not
(False).

Closes-Bug: 1917658
Change-Id: I65d4b83c56699ed566fbfb7068f9d2681ca67aa3
2021-03-12 09:24:49 -06:00
..
__init__.py Initial commit of Swift code 2010-07-12 17:03:45 -05:00
common.py ssync: sync non-durable fragments from handoffs 2021-01-20 12:00:10 +00:00
test_auditor.py Let developers/operators add watchers to object audit 2020-12-26 17:16:14 -06:00
test_diskfile.py Fix os.link exceptions in diskfile.relink_paths 2021-03-12 09:24:49 -06:00
test_expirer.py Merge "Add a new URL parameter to allow for async cleanup of SLO segments" 2020-11-18 00:50:54 +00:00
test_reconstructor.py ssync: sync non-durable fragments from handoffs 2021-01-20 12:00:10 +00:00
test_replicator.py Stop invalidating suffixes post-SSYNC 2020-11-16 08:30:07 -06:00
test_server.py Fix os.link exceptions in diskfile.relink_paths 2021-03-12 09:24:49 -06:00
test_ssync_receiver.py ssync: sync non-durable fragments from handoffs 2021-01-20 12:00:10 +00:00
test_ssync_sender.py ssync: sync non-durable fragments from handoffs 2021-01-20 12:00:10 +00:00
test_ssync.py ssync: sync non-durable fragments from handoffs 2021-01-20 12:00:10 +00:00
test_updater.py sharding: Better-handle newlines in container names 2020-01-03 16:04:57 -08:00