openstack/taskflow
Code Issues Proposed changes

Bump hacking

Browse Source 
hacking 3.0.x is too old.

Change-Id: Idbc349cbd348fb73a45c68c5f5b884c6a877ef4f
This commit is contained in:
Takashi Kajinami 2024-01-28 16:03:55 +09:00
parent 60c01f2c9a
commit 0000c79203
6 changed files with 11 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
.pre-commit-config.yaml
View File

@ -32,7 +32,7 @@ repos:
- id: flake8 - id: flake8
name: flake8 name: flake8
additional_dependencies: additional_dependencies:
- hacking>=3.0.1,<3.1.0 - hacking>=6.1.0,<6.2.0
language: python language: python
entry: flake8 entry: flake8
files: '^.*\.py$' files: '^.*\.py$'

2
taskflow/jobs/backends/impl_zookeeper.py
View File

@ -856,4 +856,4 @@ class ZookeeperJobBoard(base.NotifyingJobBoard):
"Failed to do post-connection" "Failed to do post-connection"
" initialization", cause=exc) " initialization", cause=exc)
finally: finally:
del(exc_type, exc, exc_tb) del (exc_type, exc, exc_tb)

4
taskflow/tests/unit/jobs/test_zk_job.py
View File

@ -271,12 +271,12 @@ class ZakeJobboardTest(test.TestCase, ZookeeperBoardTestMixin):
with base.connect_close(self.board): with base.connect_close(self.board):
self.board.register_entity(entity_instance) self.board.register_entity(entity_instance)
# Check '.entity' node has been created # Check '.entity' node has been created
self.assertTrue(self.board.entity_path in self.client.storage.paths) self.assertIn(self.board.entity_path, self.client.storage.paths)
conductor_entity_path = k_paths.join(self.board.entity_path, conductor_entity_path = k_paths.join(self.board.entity_path,
'conductor', 'conductor',
conductor_name) conductor_name)
self.assertTrue(conductor_entity_path in self.client.storage.paths) self.assertIn(conductor_entity_path, self.client.storage.paths)
conductor_data = ( conductor_data = (
self.client.storage.paths[conductor_entity_path]['data']) self.client.storage.paths[conductor_entity_path]['data'])
self.assertTrue(len(conductor_data) > 0) self.assertTrue(len(conductor_data) > 0)

6
taskflow/tests/unit/patterns/test_graph_flow.py
View File

@ -239,7 +239,7 @@ class GraphFlowTest(test.TestCase):
tasks = set([task1, task2, f1]) tasks = set([task1, task2, f1])
f = gf.Flow('test').add(task1, task2, f1) f = gf.Flow('test').add(task1, task2, f1)
for (n, data) in f.iter_nodes(): for (n, data) in f.iter_nodes():
self.assertTrue(n in tasks) self.assertIn(n, tasks)
self.assertDictEqual({}, data) self.assertDictEqual({}, data)
def test_iter_links(self): def test_iter_links(self):
@ -251,8 +251,8 @@ class GraphFlowTest(test.TestCase):
tasks = set([task1, task2, f1]) tasks = set([task1, task2, f1])
f = gf.Flow('test').add(task1, task2, f1) f = gf.Flow('test').add(task1, task2, f1)
for (u, v, data) in f.iter_links(): for (u, v, data) in f.iter_links():
self.assertTrue(u in tasks) self.assertIn(u, tasks)
self.assertTrue(v in tasks) self.assertIn(v, tasks)
self.assertDictEqual({}, data) self.assertDictEqual({}, data)

6
taskflow/tests/unit/patterns/test_linear_flow.py
View File

@ -130,7 +130,7 @@ class LinearFlowTest(test.TestCase):
f = lf.Flow('test').add(task1, task2, task3) f = lf.Flow('test').add(task1, task2, task3)
tasks = set([task1, task2, task3]) tasks = set([task1, task2, task3])
for (node, data) in f.iter_nodes(): for (node, data) in f.iter_nodes():
self.assertTrue(node in tasks) self.assertIn(node, tasks)
self.assertDictEqual({}, data) self.assertDictEqual({}, data)
def test_iter_links(self): def test_iter_links(self):
@ -140,6 +140,6 @@ class LinearFlowTest(test.TestCase):
f = lf.Flow('test').add(task1, task2, task3) f = lf.Flow('test').add(task1, task2, task3)
tasks = set([task1, task2, task3]) tasks = set([task1, task2, task3])
for (u, v, data) in f.iter_links(): for (u, v, data) in f.iter_links():
self.assertTrue(u in tasks) self.assertIn(u, tasks)
self.assertTrue(v in tasks) self.assertIn(v, tasks)
self.assertDictEqual({'invariant': True}, data) self.assertDictEqual({'invariant': True}, data)

2
taskflow/tests/unit/patterns/test_unordered_flow.py
View File

@ -126,7 +126,7 @@ class UnorderedFlowTest(test.TestCase):
f = uf.Flow('test') f = uf.Flow('test')
f.add(task2, task1) f.add(task2, task1)
for (node, data) in f.iter_nodes(): for (node, data) in f.iter_nodes():
self.assertTrue(node in tasks) self.assertIn(node, tasks)
self.assertDictEqual({}, data) self.assertDictEqual({}, data)
def test_iter_links(self): def test_iter_links(self):