openstack/tenks
Code Issues Proposed changes

[ansible-lint] Restore sanity

Browse Source 
1.
ansible-lint verbosity is only really required for debugging which
is best done locally, on-demand.

2.
There are almost a hundred violations of fqcn-builtins which
makes it hard to navigate ansible-lint warnings.

3.
command-instead-of-shell and 106 are no longer violated.

There are only 6 warnings now.

Change-Id: I98fb0e587373f85d78a58e84fa8051cbc18f2d8b
This commit is contained in:
Radosław Piliszek 2022-09-10 08:53:45 +00:00
parent 6ca0bb7bd6
commit 0d2fb5e71d
2 changed files with 2 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
.ansible-lint
View File

@ -1,9 +1,7 @@
skip_list:
- '106' # Role name {} does not match ``^[a-z][a-z0-9_]+$`` pattern'
- fqcn-builtins # Use FQCN for builtin actions.
warn_list:
- no-changed-when
- command-instead-of-shell # Use shell only when shell functionality is required
- experimental # all rules tagged as experimental
- fqcn-builtins # Use FQCN for builtin actions.
- jinja[spacing] # Jinja2 spacing could be improved

2
tox.ini
View File

@ -72,7 +72,7 @@ commands =
setenv = ANSIBLE_LIBRARY = {toxinidir}/ansible/action_plugins/
# Exclude roles downloaded from Galaxy (in the form 'author.role') from
# linting.
commands = bash -c "ansible-lint -vvv \
commands = bash -c "ansible-lint \
{toxinidir}/ansible/deploy.yml \
{toxinidir}/ansible/teardown.yml"