openstack/tenks
Code Issues Proposed changes

Merge "Ensure veth pairs are uniquely named"

Browse Source
This commit is contained in:
Zuul 2020-04-02 22:17:48 +00:00 committed by Gerrit Code Review
commit d8f380a975
2 changed files with 17 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
ansible/filter_plugins/tenks.py
View File

@ -201,9 +201,17 @@ def _parse_size_string(size):
def _link_name(context, node, physnet, inventory_hostname=None): def _link_name(context, node, physnet, inventory_hostname=None):
prefix = _get_hostvar(context, 'veth_prefix', prefix = _get_hostvar(context, 'veth_prefix',
inventory_hostname=inventory_hostname) inventory_hostname=inventory_hostname)
# Use up to the first 6 characters of the node name to avoid hitting the # Use up to 6 characters of the node name to avoid hitting the maximum link
# maximum link name length limit (15). # name length limit (15). Node names consist of a prefix and an index.
name = node['name'][:6] # Ensure we include the index to keep link names unique.
m = re.search(r'\d+$', node['name'])
trailing_digits = m.group()
if len(trailing_digits) > 6:
msg = ("Cannot ensure uniqueness of link names for node %s" %
node['name'])
raise AnsibleFilterError(to_text(msg))
name_prefix = node['name'][:6 - len(trailing_digits)]
name = name_prefix + trailing_digits
return (prefix + name + '-' + return (prefix + name + '-' +
str(physnet_name_to_index(context, physnet, str(physnet_name_to_index(context, physnet,
inventory_hostname=inventory_hostname))) inventory_hostname=inventory_hostname)))

6
releasenotes/notes/fix-veth-uniqueness-05bf5ebfcd5d4929.yaml Normal file
View File

@ -0,0 +1,6 @@
---
fixes:
- |
Fixes an issue where virtual Ethernet link names might not be unique. This
would cause nodes to fail to start. See `story 2007431
<https://storyboard.openstack.org/#!/story/2007431>`__ for details.