Remove unuseful become: true from deploy-steps

The ansible command generated in ansible-playbook-command.sh by default
have "--become" in it.
This commit removes "become: true" where is used to avoid confusion in
deploy steps. Today we explicitly set "become: false" in deploy-steps.j2
for certain actions, so there's no meaning of having also "become: true"
for the other ones.
We have a release note [1] that explains why the "become" was
introduces, but maybe we can revisit it.

[1] releasenotes/notes/use-become-true-in-deploy-steps-playbook-01decb18d895879f.yaml

Change-Id: Ic666b4ecaecf0591dd8bb0406f239649b20b9623
This commit is contained in:
Raoul Scarazzini 2018-06-13 16:19:25 +02:00
parent 7028d4fbe8
commit c494a508f8
2 changed files with 0 additions and 9 deletions

@ -6,7 +6,6 @@
- name: Write config data at the start of step 1
when: step == "1"
become: true
block:
- name: Create /var/lib/tripleo-config directory
file:
@ -151,7 +150,6 @@
dest: /etc/puppet/hieradata/config_step.json
force: true
mode: '0600'
become: true
- name: Run puppet host configuration for step {{ step }}
when: enable_puppet|default(true)|bool
@ -167,7 +165,6 @@
register: outputs
failed_when: false
no_log: true
become: true
- name: "Debug output for task which failed: Run puppet host configuration for step {{ step }}"
debug:
@ -193,7 +190,6 @@
register: outputs
failed_when: false
no_log: true
become: true
- name: "Debug output for task which failed: Run docker-puppet tasks (generate config) during step {{ step }}"
debug:
@ -218,7 +214,6 @@
register: outputs
failed_when: false
no_log: true
become: true
- name: "Debug output for task which failed: Start containers for step {{ step }}"
debug:
@ -234,7 +229,6 @@
stat:
path: /var/lib/docker-puppet/docker-puppet-tasks{{ step }}.json
register: docker_puppet_tasks_json
become: true
- name: Run docker-puppet tasks (bootstrap tasks) for step {{ step }}
shell: python /var/lib/docker-puppet/docker-puppet.py
@ -251,7 +245,6 @@
register: outputs
failed_when: false
no_log: true
become: true
- name: "Debug output for task which failed: Run docker-puppet tasks (bootstrap tasks) for step {{ step }}"
debug:

@ -463,7 +463,6 @@ outputs:
any_errors_fatal: yes
vars:
bootstrap_server_id: BOOTSTRAP_SERVER_ID
become: true
tasks:
{%- for role in roles %}
- include: {{role.name}}/host_prep_tasks.yaml
@ -659,7 +658,6 @@ outputs:
DEPLOY_TARGET_HOST: {get_param: deployment_target_hosts}
template: |
- hosts: DEPLOY_TARGET_HOST
become: true
tasks:
- set_fact:
releases: {get_param: [FastForwardUpgradeReleases]}