8601 Commits

Author SHA1 Message Date
Cédric Jeanneret
9aab4de972 Load iscsi_tcp module from the host.
Until now, it's loaded from within the container, this doesn't work
with SELinux separation.

Change-Id: Ia2cd08b9b7950ebca4d75938ae4329641c2d6f7c
Depends-on: Ic9076a0a1a8e1360495dcf0eb766118ec63dc362
Related-Bug: 1794550
2018-10-08 08:37:35 +02:00
Janki Chhatbar
865e8b574c Add provision to specify java arguments to ODL
Java options like heap size configuration needs
tweaking for large scale deployments. Allow
customizing those values from TripleO.

puppet-opendaylight will configure these values
in ODL. Corresponding puppet-opendaylight patch is
https://git.opendaylight.org/gerrit/#/c/68491

Change-Id: I99e08314dedfcc71a776423ac3c6c282237cc0c2
Closes-Bug: #1794073
2018-10-08 10:32:36 +05:30
Zuul
6adc2f3f85 Merge "Add config option for ODL IPv6 deployment" 2018-10-07 23:11:50 +00:00
Zuul
474b252358 Merge "ceilometer: Use new archive policies" 2018-10-07 09:06:33 +00:00
Zuul
4124ca7e27 Merge "Enable health check for OVN containers" 2018-10-07 08:42:39 +00:00
Zuul
17933be619 Merge "Fix TLS when using a containerized undercloud" 2018-10-07 00:52:09 +00:00
Zuul
94baf0b87d Merge "check mode: puppet host" 2018-10-07 00:52:05 +00:00
Zuul
94459f43d1 Merge "Add tripleo-heat-templates dir to Mistral volumes" 2018-10-07 00:36:11 +00:00
Zuul
ca47673df9 Merge "This file intorduces OVN as a controller. I've cloned the neutron-sfc.yaml file and added to the parameter_defaults NeutronSfcDriver:'ovn' There could be other param defaults needs to be added and i'm not aware of." 2018-10-07 00:36:08 +00:00
Zuul
8071badcb7 Merge "Revert "Allow a containerized logrotate to access docker"" 2018-10-07 00:36:04 +00:00
Zuul
ec67cd6afa Merge "Consolidate openshift-ansible global variables" 2018-10-06 15:21:02 +00:00
Zuul
5c6813a696 Merge "Make glusterfs the default sc when deploying with CNS" 2018-10-06 15:19:15 +00:00
Zuul
57e90388d5 Merge "Introduce OpenShiftGlusterNodeVars heat param" 2018-10-06 15:19:14 +00:00
Zuul
8e7cdb9fe4 Merge "Fix inventory files for newer openshift-ansible" 2018-10-06 15:02:30 +00:00
Michele Baldessari
c2139a7db2 Fix TLS when using a containerized undercloud
Since we moved to containerized UC, TLS Everywhere deployments are broken.
Namely we miss two things:

A. The NAT iptables rule for the nova metadata service to be reachable
B. The setting 'service_metadata_proxy=false' needs to be set for nova
   metadata otherwise the curl calls to setup ipa will fail with the
   following:
[root@overcloud-controller-0 log]# curl http://169.254.169.254/openstack/2016-10-06
<html>
 <head>
  <title>400 Bad Request</title>
 </head>
 <body>
  <h1>400 Bad Request</h1>
  X-Instance-ID header is missing from request.<br /><br />
 </body>
</html>

A. Is fixed by adding a conditional iptables rule that is only triggered
   when deploying an undercloud (where we set MetadataNATRule to true)

B. Is fixed by setting NeutronMetadataProxySharedSecret to '' on the
   undercloud and then setting the corresponding hiera keys only when
   the parameter != ''. We tried alternative simpler approaches like
   setting NeutronMetadataProxySharedSecret to null but that will break
   heat as the parameter is required and setting it to null breaks heat
   validation (we also tried to make the parameter optional with a
   default: '', but that broke as well)

While we're at it we also remove the neutron metadata service from the
undercloud as it is not needed.

Tested by deploying an undercloud with this change and observing:
A.
Chain PREROUTING (policy ACCEPT 106 packets, 6698 bytes)
 pkts bytes target     prot opt in     out     source               destination
    0     0 REDIRECT   tcp  --  br-ctlplane *       0.0.0.0/0            169.254.169.254      multiport dports 80 state NEW /* 999 undercloud nat ipv4 */ redir ports 8775

B.
grep -ir ^service_metadata_proxy /var/lib/config-data/puppet-generated/nova/etc/nova/nova.conf
service_metadata_proxy=False

Also a deployment of a TLS overcloud was successful.

Change-Id: Id48df6db012fb433f9a0e618d0269196f4cfc2c6
Co-Authored-By: Martin Schuppert <mschuppe@redhat.com>
Closes-Bug: #1795722
2018-10-06 13:25:18 +00:00
Zuul
5d2b9a420e Merge "Configure haproxy for openshift infra" 2018-10-06 12:46:01 +00:00
Zuul
7495f12a7c Merge "Fix error in Tenant network routes definition" 2018-10-06 02:04:11 +00:00
John Fulton
977de9821b Ensure ceph-ansible source directory is present
Docker doesn't complain when a directory doesn't exist
in a bind mount, while Podman does complain. Ensure the
directory is present in the mistral-executor container
host prep tasks.

Change-Id: I32993c6dfbd561c16ef1fdce508bf899aff1d940
Fixes-Bug: #1796188
2018-10-05 19:40:58 +00:00
Alex Schultz
7d35d24164 Remove 3node from CI
This job is continually broken and just eats up resources. Let's remove
this for now.

Change-Id: I0f734a27c62e0ee0801001c522b1903354b1de4e
2018-10-05 10:55:31 -06:00
Janki Chhatbar
53b2cc0b56 Add config option for ODL IPv6 deployment
Add a flag to specify which IP version to
deploy ODL on via Puppet-ODL.

Change-Id: Idd257cf4666b853eb4c52861f9f400b6dbdeeadb
Closes-Bug: #1783196
2018-10-05 07:49:51 +00:00
Zuul
051f4e0059 Merge "Remove parameter reference to non-exisingt parameter" 2018-10-05 01:37:25 +00:00
Juan Antonio Osorio Robles
f4b4a33860 Use valid_interfaces instead of os_interface for placement
os_interface is deprecated, we should switch.

Change-Id: I911576df939e6bc957f6c4422792d66a540129b6
2018-10-04 16:01:02 +03:00
Juan Antonio Osorio Robles
f2e72352b1 Fix placement region setting
We were using a deprecated interfce to set this value. This uses the
correct one.

Closes-Bug: #1793665
Change-Id: Ib7717911aba3267f855ac6682b0144bfe92034fb
2018-10-04 15:58:50 +03:00
Jiri Stransky
bcd6cde608 Introduce proper steps to external update/upgrade tasks
So far the tasks for external update/upgrade were not using the step
mechanism as other tasks, we had a single step. As external
deploy/update/upgrade tasks are being used for more things nowadays,
it's likely that we'll need to go towards a similar model like we have
for deploy/update/upgrade tasks -- proper usage of steps.

For now we have just 2:

* Step 0 for setting global facts, and performing validations.

* Step 1 for actual update/upgrade tasks. (There's an upcoming change
  to run online data migrations in step 1).

Change-Id: I1933bd0eedab71caab56c0e5d93ba7927fb7c20f
Partial-Bug: #1793332
2018-10-04 12:08:21 +02:00
Zuul
9f93bb7a9e Merge "Convert with_dict tasks to use loop and be less chatty" 2018-10-03 22:25:57 +00:00
Zuul
5c3ed37336 Merge "Configure http/https on OVN Metadata service to talk to Nova" 2018-10-03 19:30:17 +00:00
Zuul
01475936bd Merge "Chunk up ceph-ansible output to prevent clogging the CLI" 2018-10-03 19:29:26 +00:00
Martin André
c67c345541 Consolidate openshift-ansible global variables
Merge openshift/global_defaults.yml into openshift/global_vars.yml file
since they serve the exact same purpose.

Also remove duplicated variables that were set in inventory file for
glusterfs nodes.

Change-Id: Ic0fb84fb7c711d4706b75885e69cbd052cd56f42
2018-10-03 18:49:44 +00:00
Martin André
d90bb11ea4 Make glusterfs the default sc when deploying with CNS
GlusterFS is the recommended storage solution for OpenShift. Mark the
deployed GlusterFS cluster as the default storage class when deploying
with CNS.

This is possible to change it back to not being the default storage
class by setting 'openshift_storage_glusterfs_storageclass_default:
false' in the OpenShiftGlusterNodeVars heat parameter.

Change-Id: I6810709263e3cda56fa3aa70797bcc5ca1b28671
2018-10-03 18:49:39 +00:00
Martin André
bd5dddb58d Introduce OpenShiftGlusterNodeVars heat param
Removes conflict on OpenShiftGlobalVariables param that was overwritten
by the openshift-cns.yaml environment file. The default options for CNS
as now moved into the extraconfig/services/openshift-cns.yaml template
and can be overwritten by setting the OpenShiftGlusterNodeVars heat
parameter.

Change-Id: I43052662e913a02945f22e9f541a45ce2d9d828c
2018-10-03 18:49:33 +00:00
Martin André
a04ceaa407 Fix inventory files for newer openshift-ansible
The openshift_hostname variable added to the nodes was causing the
openshift-ansible to check for pods with names that didn't match the
real name of the pods, i.e. names composed of IP addresses vs
hostnames.

Change-Id: I794558bd6048e68e03540c10191f44aaa9fdb707
2018-10-03 18:48:13 +00:00
Zuul
3a8956cee8 Merge "Set the number of RPC workers to 1 for non SRIOV OVN setups" 2018-10-03 16:03:12 +00:00
Zuul
7ea21fff23 Merge "Mount /usr/share/ceph-ansible into mistral-executor" 2018-10-03 16:00:19 +00:00
Jiri Stransky
580fb660df Tag container image prepare tasks to allow running them for updates/upgrades
Updates/upgrades workflow must not run during `upgrade prepare` or
`upgrade run`, but during `upgrade run` we need to have the images
available. So the intention is to run `external-upgrade run --tags
container_image_prepare` between `upgrade prepare` and `upgrade run`.

The situation is analogical for `update` and `external-update`
commands.

Change-Id: I49de9a41c62204ab7cd835fec6dab8d59b054948
Closes-Bug: #1795881
2018-10-03 14:51:46 +02:00
Zuul
34b6aab229 Merge "Remove unused bootstrap-config.yaml" 2018-10-03 12:01:18 +00:00
James Slagle
538c894317 Name unnamed tasks
These tasks had an empty name field, which breaks ansible's
--start-at-task functionality with a traceback, as it's not valid to
have unnamed tasks.

Change-Id: I2386da62a87bfc290070fce13c2d35290565478a
2018-10-03 07:47:20 -04:00
James Slagle
b76a36eca1 check mode: paunch configs
Adds initial check mode support for the paunch container startup
configuration and kolla config files. This cleans up the formatting of
the generated files so that the diff shown duing check mode with --diff
is useful.

We can't actually run paunch during check mode as it doesn't yet have
any support for a dry run mode.

Change-Id: I9add7b9fda50847c111e91735bd55a1ddf32f696
2018-10-03 07:47:20 -04:00
James Slagle
29f05e1e6f check mode: docker_puppet_tasks
Adds check mode support for docker_puppet_tasks.

Since it's not possible to reliably determine what these tasks do, we
can't actually run them to get an idea of what might be changed. We can
however show the diff of the json file to get an idea of what would be
run.

Change-Id: I19e8bc9eb93d8acc8ee7d737770f9cc7e63f7a27
2018-10-03 07:47:20 -04:00
James Slagle
a6f9821821 check mode: docker_puppet
Adds check mode support for docker_puppet. The updated json file is
written to /var/lib/docker-puppet/check-mode/docker-puppet.json
during check mode and then diffed with the existing version at
/var/lib/docker-puppet/docker-puppet.json.

When docker-puppet.py is run during check mode, the updated json file
under the check-mode directory is passed to the command. All generated
config files are then written under /var/lib/config-data/check-mode,
which is then recursively diffed with the existing config under just
/var/lib/config-data to report on all changed config files.

Change-Id: I5c831e9546f8b6edaf3b0fda6c9fbef86c825a4c
2018-10-03 07:47:16 -04:00
Bogdan Dobrelya
bd2b7a1856 Revert "Allow a containerized logrotate to access docker"
not needed any more as we fallback to copytruncate

This reverts commit 2b1afc0483f849046b404099944653015fc11a04.

Change-Id: I8c2ad6329b5c4226edae9ea80baf3bca8dd06e65
2018-10-03 09:48:27 +00:00
Zuul
77088da1b8 Merge "Add UseNotifySSL to environments/ssl/enable-internal-tls.yaml" 2018-10-03 09:37:28 +00:00
Jiri Stransky
a0ead2f1a7 Chunk up ceph-ansible output to prevent clogging the CLI
The CLI commands running Ansible can crash if we send too much
single-line log output their way. This was happening on upgrades, when
we run Ansible with verbosity level 1.

The fix is twofold:

* If ceph-ansible finishes successfully, we don't print the
  ceph-ansible output into the main log.

* If ceph-ansible fails, we do print the output, but we print it
  line-by-line, which should give us much better readability than
  before, and we shouldn't break the limits of the Mistral-Zaqar-CLI
  message passing.

Change-Id: I6e0fc36749e74fce25f414c2547e49e2a20437ab
Closes-Bug: #1795689
2018-10-03 11:21:34 +02:00
Zuul
51410f0e88 Merge "Add a zaqar-swift-backend environment file" 2018-10-03 01:44:37 +00:00
Zuul
dc2f4e7556 Merge "Persist ceph-ansible fetch_directory using config-download" 2018-10-03 01:42:50 +00:00
Zuul
42a6e65632 Merge "Remove unused parameter NeutronEnableDHCPAgent" 2018-10-03 01:42:49 +00:00
Zuul
5441c5fbd0 Merge "In process-templates script write output files to provided dir when using base path" 2018-10-02 21:46:04 +00:00
Zuul
32b1ba58e7 Merge "Fix privileged typo in docker-puppet.py" 2018-10-02 21:46:02 +00:00
Zuul
ef1056d8e3 Merge "docker-puppet.py: used dedicated hiera entry, not uuid" 2018-10-02 18:52:05 +00:00
Zuul
714706ff6e Merge "Don't configure BIND to listen on localhost" 2018-10-02 18:52:03 +00:00
Zuul
b600b860c0 Merge "Update standalone role" 2018-10-02 18:52:00 +00:00