Michele Baldessari c93489cfbe Enable logging to stdout/stderr in memcached
Even though https://bugs.launchpad.net/tripleo/+bug/1776889 got fixed,
memcached is still configured to log to a file due to the way
puppet-memcached works:
- It would omit logging to a file when the logfile parameter (which has
  a default value) is set to undef
- In puppet/hiera undeffing a parameter that has a default value does
  not work: https://tickets.puppetlabs.com/browse/PUP-5295

In fact even after the fixes from https://bugs.launchpad.net/tripleo/+bug/1776889 get included we still see the following:
[root@rhosp-ctr01 ~]# ps -ef | grep memcached
42457 44366 44342 0 10:06 ? 00:00:00 /bin/bash -c source /etc/sysconfig/memcached; /usr/bin/memcached -p ${PORT} -u ${USER} -m ${CACHESIZE} -c ${MAXCONN} $OPTIONS
42457 44385 44366 0 10:06 ? 00:00:08 /usr/bin/memcached -p 11211 -u memcached -m 16005 -c 8192 -v -l 192.168.18.11 -U 0 -t 8 >> /var/log/memcached.log 2>&1

This change depends on the following memcached PR:
https://github.com/saz/puppet-memcached/pull/99/files to work correctly.

With this patch memcached logs to stdout/err correctly:
[root@overcloud-controller-0 etc]# ps auxwfw |grep memcache
42457      37207  0.0  0.0  11680  1396 ?        Ss   19:23   0:00      |   \_ /bin/bash -c source /etc/sysconfig/memcached; /usr/bin/memcached -p ${PORT} -u ${USER} -m ${CACHESIZE} -c ${MAXCONN} $OPTIONS
42457      37224  0.0  0.0 293160  3724 ?        Sl   19:23   0:00      |       \_ /usr/bin/memcached -p 11211 -u memcached -m 5877 -c 8192 -v -l 172.16.2.14 -U 0 -X -t 2

Change-Id: I8cec029bd1f64ec1daa76a89e949e7d245580918
Closes-Bug: #1782223
2018-07-19 08:31:31 +02:00

139 lines
4.7 KiB
YAML

heat_template_version: rocky
description: >
OpenStack containerized Memcached services
parameters:
DockerMemcachedImage:
description: image
type: string
DockerMemcachedConfigImage:
description: The container image to use for the memcached config_volume
type: string
EndpointMap:
default: {}
description: Mapping of service endpoint -> protocol. Typically set
via parameter_defaults in the resource registry.
type: json
ServiceData:
default: {}
description: Dictionary packing service data
type: json
ServiceNetMap:
default: {}
description: Mapping of service_name -> network name. Typically set
via parameter_defaults in the resource registry. This
mapping overrides those in ServiceNetMapDefaults.
type: json
DefaultPasswords:
default: {}
type: json
RoleName:
default: ''
description: Role name on which the service is applied
type: string
RoleParameters:
default: {}
description: Parameters specific to the role
type: json
resources:
ContainersCommon:
type: ./containers-common.yaml
MemcachedBase:
type: ../../puppet/services/memcached.yaml
properties:
EndpointMap: {get_param: EndpointMap}
ServiceData: {get_param: ServiceData}
ServiceNetMap: {get_param: ServiceNetMap}
DefaultPasswords: {get_param: DefaultPasswords}
RoleName: {get_param: RoleName}
RoleParameters: {get_param: RoleParameters}
outputs:
role_data:
description: Role data for the Memcached API role.
value:
service_name: {get_attr: [MemcachedBase, role_data, service_name]}
config_settings:
map_merge:
- {get_attr: [MemcachedBase, role_data, config_settings]}
- memcached::logstdout: true
logging_source: {get_attr: [MemcachedBase, role_data, logging_source]}
logging_groups: {get_attr: [MemcachedBase, role_data, logging_groups]}
service_config_settings: {get_attr: [MemcachedBase, role_data, service_config_settings]}
# BEGIN DOCKER SETTINGS
puppet_config:
config_volume: 'memcached'
puppet_tags: 'file'
step_config:
get_attr: [MemcachedBase, role_data, step_config]
config_image: {get_param: DockerMemcachedConfigImage}
kolla_config: {}
docker_config:
step_1:
memcached:
start_order: 0
image: {get_param: DockerMemcachedImage}
net: host
privileged: false
restart: always
healthcheck:
test: /openstack/healthcheck
volumes:
list_concat:
- {get_attr: [ContainersCommon, volumes]}
-
- /var/lib/config-data/memcached/etc/sysconfig/memcached:/etc/sysconfig/memcached:ro
command: ['/bin/bash', '-c', 'source /etc/sysconfig/memcached; /usr/bin/memcached -p ${PORT} -u ${USER} -m ${CACHESIZE} -c ${MAXCONN} $OPTIONS']
host_prep_tasks:
- name: memcached logs readme
copy:
dest: /var/log/memcached-readme.txt
content: |
Memcached container logs to stdout/stderr only.
ignore_errors: true
upgrade_tasks:
- when: step|int == 0
tags: common
block:
- name: Check if memcached is deployed
command: systemctl is-enabled --quiet memcached
ignore_errors: True
register: memcached_enabled_result
- name: Set fact memcached_enabled
set_fact:
memcached_enabled: "{{ memcached_enabled_result.rc == 0 }}"
- name: "PreUpgrade step0,validation: Check service memcached is running"
command: systemctl is-active --quiet memcached
when: memcached_enabled|bool
tags: validation
- when: step|int == 2
block:
- name: Stop and disable memcached service
when: memcached_enabled|bool
service: name=memcached state=stopped enabled=no
fast_forward_upgrade_tasks:
- name: Check if memcached is deployed
command: systemctl is-enabled --quiet memcached
tags: common
ignore_errors: True
register: memcached_enabled_result
when:
- step|int == 0
- release == 'ocata'
- name: memcached_enabled
set_fact:
memcached_enabled: "{{ memcached_enabled_result.rc == 0 }}"
when:
- step|int == 0
- release == 'ocata'
- name: Stop and disable memcached service
when:
- step|int == 2
- release == 'ocata'
- memcached_enabled|bool
service: name=memcached state=stopped enabled=no