openstack/trove
Code Issues Proposed changes

Increase test rate limit to avoid rate limit error

Browse Source 
The current rate limit is 200 requests per minute. I'm getting
consistent tox failures as the machine is exceeding this rate. The fix
impacts only test code and adjusts the limit and a test that has a
hard-coded reference to the old limit. Why 500 you may ask? Because
600 worked and 450 failed consistently with the rate limit error.

In addition, the change addresses the fact that some test
configuration values are duplicated in the test; the change makes the
test reference the configuration value.

Change-Id: I4bb290d8de6253d65b7877c743bb288ee2bce536
Closes-Bug: #1376689
Closes-Bug: #1378932
This commit is contained in:
Amrith Kumar 2014-10-02 08:19:38 -04:00 committed by amrith
parent 99d0e16100
commit a67c0ca703
2 changed files with 12 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
etc/trove/trove.conf.test
View File

@ -90,10 +90,10 @@ max_backups_per_user = 5
volume_time_out=30
# Config options for rate limits
http_get_rate = 200
http_post_rate = 200
http_put_rate = 200
http_delete_rate = 200
http_get_rate = 500
http_post_rate = 500
http_put_rate = 500
http_delete_rate = 500
# default datastore
default_datastore = a00000a0-00a0-0a00-00a0-000a000000aa

12
trove/tests/api/limits.py
View File

@ -22,6 +22,7 @@ from nose.tools import assert_true
from proboscis import before_class
from proboscis import test
from trove.common import cfg
from trove.openstack.common import timeutils
from trove.tests.util import create_dbaas_client
from troveclient.compat import exceptions
@ -29,11 +30,14 @@ from datetime import datetime
from trove.tests.util.users import Users
from trove.tests.fakes import limits as fake_limits
CONF = cfg.CONF
GROUP = "dbaas.api.limits"
DEFAULT_RATE = 200
DEFAULT_MAX_VOLUMES = 100
DEFAULT_MAX_INSTANCES = 55
DEFAULT_MAX_BACKUPS = 5
DEFAULT_RATE = CONF.http_get_rate
DEFAULT_MAX_VOLUMES = CONF.max_volumes_per_user
DEFAULT_MAX_INSTANCES = CONF.max_instances_per_user
DEFAULT_MAX_BACKUPS = CONF.max_backups_per_user
def ensure_limits_are_not_faked(func):