openstack/trove
Code Issues Proposed changes

Mask passwords in configuration-show

Browse Source 
Use the mask_dict_password util on the configuration view.

Change-Id: Ifbc2f317d217497ce6aad05423f5af7dc883721c
Closes-Bug: #1645792
This commit is contained in:
Matt Van Dijk 2016-10-11 12:20:23 -04:00 committed by Trevor McCasland
parent adff356315
commit f7d41c7b7c
2 changed files with 6 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
releasenotes/notes/mask-configuration-passwords-317ff6d2415b2ca1.yaml Normal file
View File

@ -0,0 +1,3 @@
---
security:
- Configuration show masks any password values.

4
trove/configuration/views.py
View File

@ -13,6 +13,8 @@
# License for the specific language governing permissions and limitations # License for the specific language governing permissions and limitations
# under the License. # under the License.
from oslo_utils import strutils
class ConfigurationView(object): class ConfigurationView(object):
@ -93,7 +95,7 @@ class DetailedConfigurationView(object):
"id": self.configuration.id, "id": self.configuration.id,
"name": self.configuration.name, "name": self.configuration.name,
"description": self.configuration.description, "description": self.configuration.description,
"values": values, "values": strutils.mask_dict_password(values),
"created": self.configuration.created, "created": self.configuration.created,
"updated": self.configuration.updated, "updated": self.configuration.updated,
"instance_count": "instance_count":