openstack/validations-common
Code Issues Proposed changes

Merge "Fixed exception handling of the print_tuple_table method."

Browse Source
This commit is contained in:
Zuul 2021-04-27 16:51:37 +00:00 committed by Gerrit Code Review
commit 5e9cb46601
1 changed files with 8 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
validations_common/validation.py
View File

@ -176,7 +176,12 @@ class Validation(argparse.ArgumentParser):
t.add_row(r) t.add_row(r)
print(t) print(t)
else: else:
raise RuntimeError("Wrong data type.") raise TypeError(
(
"data must be of 'tuple' type. "
"Instead {} was provided."
).format(type(data))
)
def _write_output(self, output_log, results): def _write_output(self, output_log, results):
"""Write output log file as Json format""" """Write output log file as Json format"""
@ -198,9 +203,9 @@ class Validation(argparse.ArgumentParser):
if extra_vars: if extra_vars:
try: try:
extra_vars = dict(e.split("=") for e in parsed_args.extra_vars) extra_vars = dict(e.split("=") for e in parsed_args.extra_vars)
except ValueError: except ValueError as error:
msg = "extra vars option should be formed as: KEY=VALUE." msg = "extra vars option should be formed as: KEY=VALUE."
raise RuntimeError(msg) raise RuntimeError(msg) from error
v_actions = ValidationActions(validation_path=validation_dir, v_actions = ValidationActions(validation_path=validation_dir,
group=group) group=group)
if 'run' in action: if 'run' in action: