[pre-commit] Fix execute and shebang lines

This commit removes the execute bit from several files
and remove the shebang lines from the devstack plugin.

While the devstack plugin is written in bash, it is not an executable
script. The devstack plugin is sourced by devstack as needed,
as such it is not executed in a subshell and the #!/bin/bash
lines are not used even when present.

Change-Id: I82ca22b7a47bf267fe6cf11f3e3519510108c146

.pre-commit-config.yaml

@@ -16,10 +16,8 @@ repos:
         files: .*\.json$
       - id: check-yaml
         files: .*\.(yaml|yml)$
-      # FIXME(sean-k-mooney): we currently have some files
+      - id: check-executables-have-shebangs
-      # with incorrect permission, resolve this in a follow up
+      - id: check-shebang-scripts-are-executable
-      # - id: check-executables-have-shebangs
-      # - id: check-shebang-scripts-are-executable
       # git
       - id: check-added-large-files
       - id: check-case-conflict

devstack/lib/watcher

@@ -1,5 +1,3 @@
-#!/bin/bash
-#
 # lib/watcher
 # Functions to control the configuration and operation of the watcher services
 

devstack/plugin.sh

@@ -1,5 +1,3 @@
-#!/bin/bash
-#
 # plugin.sh - DevStack plugin script to install watcher
 
 # Save trace setting

devstack/upgrade/from_rocky/upgrade-watcher

@@ -1,5 +1,3 @@
-#!/usr/bin/env bash
-
 # ``upgrade-watcher``
 
 function configure_watcher_upgrade {