6679a3853a
Previously, our compute base class overwrote some clients with their admin versions. This is needlessly confusing. This patch just removes the setup_clients() method altogether, along with the create_test_server() override, and forces tests to explicitly use either self.os_primary or self.os_admin as the clients. This change has a few simple but widespread consequences: * We need to start using self.get_host_for_server() in a few places, instead of looking up the 'OS-EXT-SRV-ATTR:host' attribute in the server dict, as that's only present in the admin response. * We can drop the public visibility in copy_default_image(), as that's only allowed for admins, and the default shared visibility should work just as well for us. * The unit test for list_compute_hosts() would need to get fixed to account for the use of self.os_admin.services_client instead of self.services_client. Rather than do that, just drop the test entirely, it adds no value as list_compute_hosts() is used in whitebox tests themselves. * We need to start explicitly plassing wait_until='ACTIVE' to every one of our create_test_server calls, as the override used to do that for us. * Our live_migrate() helper now needs to be passed a clients manager so that it can pass that through to the waiter when waiting for the server to reach a particular status after the live migration. Depends-on: https://review.opendev.org/c/openstack/tempest/+/820062 Change-Id: I8d5be63275bd8a28b7012e14b99cadafdea53a47
54 lines
1.9 KiB
Python
54 lines
1.9 KiB
Python
# Copyright 2021 Red Hat
|
|
# All Rights Reserved.
|
|
#
|
|
# Licensed under the Apache License, Version 2.0 (the "License"); you may
|
|
# not use this file except in compliance with the License. You may obtain
|
|
# a copy of the License at
|
|
#
|
|
# http://www.apache.org/licenses/LICENSE-2.0
|
|
#
|
|
# Unless required by applicable law or agreed to in writing, software
|
|
# distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
|
|
# WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
|
|
# License for the specific language governing permissions and limitations
|
|
# under the License.
|
|
|
|
from oslo_log import log as logging
|
|
from tempest import config
|
|
|
|
from whitebox_tempest_plugin.api.compute import base
|
|
|
|
CONF = config.CONF
|
|
LOG = logging.getLogger(__name__)
|
|
|
|
|
|
class TestVirtIORng(base.BaseWhiteboxComputeTest):
|
|
"""Tests checking VirtIO Rng device in the
|
|
server XML
|
|
"""
|
|
|
|
@classmethod
|
|
def skip_checks(cls):
|
|
super(TestVirtIORng, cls).skip_checks()
|
|
if not CONF.compute_feature_enabled.virtio_rng:
|
|
skip_msg = ("%s skipped as virtio-rng is "
|
|
"not enabled" % cls.__name__)
|
|
raise cls.skipException(skip_msg)
|
|
|
|
def test_virtio_rng_model(self):
|
|
server = self.create_test_server(wait_until='ACTIVE')
|
|
domain = self.get_server_xml(server['id'])
|
|
rng_device = domain.find("devices/rng")
|
|
self.assertEqual(
|
|
rng_device.attrib['model'], 'virtio',
|
|
"VirtIO-RNG device not present")
|
|
|
|
def test_set_rng_device_false(self):
|
|
extra_specs = {'hw_rng:allowed': 'False'}
|
|
flavor_id = self.create_flavor(
|
|
extra_specs=extra_specs)['id']
|
|
server = self.create_test_server(flavor=flavor_id,
|
|
wait_until='ACTIVE')
|
|
domain = self.get_server_xml(server['id'])
|
|
self.assertIsNone(domain.find("devices/rng"))
|