From dbf603b4c45e865e56a21d3b14d94bcc8d5f455c Mon Sep 17 00:00:00 2001
From: albailey <Al.Bailey@windriver.com>
Date: Mon, 11 May 2020 10:29:45 -0500
Subject: [PATCH] Reduce the number of suppressed pylint warnings

All pylint warnings were being suppressed by a wildcard.
This commit only suppresses the warnings that are failing and
prevents checks that would pass from being broken in later commits.

The warnings being suppressed can be resolved individually
by later submissions based on priority where appropriate.

This commit also specifies python3 for pylint which has
more recent checks.

Change-Id: Ie29aeb0ea3e9dcb671af67f38e9a3f919ea7111e
Story: 2004515
Task: 39734
Signed-off-by: albailey <Al.Bailey@windriver.com>
---
 distributedcloud/pylint.rc | 33 +++++++++++++++++++++++++++++++--
 distributedcloud/tox.ini   |  2 +-
 2 files changed, 32 insertions(+), 3 deletions(-)

diff --git a/distributedcloud/pylint.rc b/distributedcloud/pylint.rc
index 561657449..9ceff7dc6 100644
--- a/distributedcloud/pylint.rc
+++ b/distributedcloud/pylint.rc
@@ -35,12 +35,41 @@ load-plugins=
 # R detect Refactor for a "good practice" metric violation
 # C detect Convention for coding standard violation
 # W detect Warning for stylistic problems, or minor programming issues
+# W0102: dangerous-default-value
+# W0105: pointless-string-statement
+# W0107: unnecessary-pass
+# W0123: eval-used
+# W0201: attribute-defined-outside-init
+# W0211: bad-staticmethod-argument
+# W0212: protected-access
+# W0221: arguments-differ
+# W0223: abstract-method
+# W0231: super-init-not-called
+# W0235: useless-super-delegation
+# W0311: bad-indentation
+# W0402: deprecated-module
+# W0403: relative-import
+# W0603: global-statement
+# W0612: unused-variable
+# W0613: unused-argument
+# W0621: redefined-outer-name
+# W0622: redefined-builtin
+# W0631: undefined-loop-variable
+# W0703: broad-except
+# W0706: try-except-raise
+# W1113: keyword-arg-before-vararg
+# W1201: logging-not-lazy
+# W1401: anomalous-backslash-in-string
 # E detect Errors for important programming issues (i.e. most probably bug)
 # E1101: no-member
 # E1102: not-callable
 # E1120: no-value-for-parameter  (sqlalchemy)
-disable=C,R,W,
-        E1101,E1102,E1120
+# E1128: assignment-from-none
+disable=C,R,fixme,
+        W0102,W0105,W0107,W0123,W0201,W0211,W0212,W0221,W0223,W0231,W0235,
+        W0311,W0402,W0403,W0603,W0612,W0613,W0621,W0622,W0631,W0703,W0706,
+        W1113,W1201,W1401,
+        E1101,E1102,E1120,E1128
 
 
 [REPORTS]
diff --git a/distributedcloud/tox.ini b/distributedcloud/tox.ini
index 56c3824f5..cd5adbec8 100644
--- a/distributedcloud/tox.ini
+++ b/distributedcloud/tox.ini
@@ -170,7 +170,7 @@ commands =
 import_exceptions = dcmanager.common.i18n,dcorch.common.i18n
 
 [testenv:pylint]
-basepython = python2.7
+basepython = python3
 sitepackages = False
 deps = {[testenv:py27]deps}
        -e{[dc]cgcs_patch_src_dir}