starlingx/integ
Code Issues Proposed changes

speclint: only show the diff files

Browse Source 
Since we moved the specfile into the tempdir so that it can be modified
the final checks are showing all the specfiles even if they pass the
spec cleaner process.

Also don't reset the failed variable.

Fix the argument check for multiple files

Change-Id: I0a7c33f0ce4f31607bb518a2a899a522cdd7fd4c
Signed-off-by: Saul Wold <sgw@linux.intel.com>
This commit is contained in:
Saul Wold 2019-06-25 15:21:04 -07:00
parent 6cea1d1e4c
commit 92405a9ad7
1 changed files with 4 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
tools/spec-tools/speclint.sh
View File

@ -14,7 +14,7 @@ usage() {
exit 1 exit 1
} }
if [ -z $@ ]; then if [ ${#@} -eq 0 ]; then
usage usage
fi fi
@ -65,7 +65,7 @@ for spec in $@; do
(cd $(dirname $spec); HOME=$tmpdir rpmspec -q --qf "%{VERSION}\n" $specname) >/dev/null || { (cd $(dirname $spec); HOME=$tmpdir rpmspec -q --qf "%{VERSION}\n" $specname) >/dev/null || {
echo "$spec does not parse properly. Please check your syntax." echo "$spec does not parse properly. Please check your syntax."
failed=1 failed=1
} }
echo "spec-cleaner checking $specname" echo "spec-cleaner checking $specname"
# Make a copy to do some fix-ups required by spec-cleaner # Make a copy to do some fix-ups required by spec-cleaner
@ -84,10 +84,9 @@ for spec in $@; do
done done
# check if some diffs are available # check if some diffs are available
failed=0 for specdiff in $tmpdir/*.cleaner.diff; do
for specdiff in $tmpdir/*; do
if [ -s "$specdiff" ]; then if [ -s "$specdiff" ]; then
echo "##### `basename ${specdiff}` ##### " echo "##### `basename ${specdiff} .cleaner.diff` ##### "
cat $specdiff cat $specdiff
failed=1 failed=1
fi fi