ccfeeef59d
Backport the patches for this issue: https://bugzilla.redhat.com/show_bug.cgi?id=1819868 We met such an issue: When testing a large number of pods (> 230), occasionally observed a number of issues related to systemd process: systemd ran continually 90-100% cpu usage systemd memory usage started increasing rapidly (20GB/hour) systemctl commands would always timeout (Failed to get properties: Connection timed out) sm services failed and can't recover: open-ldap, registry-token-server, docker-distribution, etcd new pods can't start, and got stuck in state ContainerCreating Those patches work to prevent excessive /proc/1/mountinfo reparsing. It has been verified that those patches can improve this performance greatly. 16 commits are listed in sequence (from [1] to [16]) at below link for the issue: https://github.com/systemd-rhel/rhel-8/pull/154/commits [16](10)core: prevent excessive /proc/self/mountinfo parsing [15][Dropped-6]test: add ratelimiting test [14](9)sd-event: add ability to ratelimit event sources [13](8)sd-event: increase n_enabled_child_sources just once [12](7)sd-event: update state at the end in event_source_enable [11](6)sd-event: remove earliest_index/latest_index into common part of event source objects [10][Dropped-5]sd-event: follow coding style with naming return parameter [9] [Dropped-4]sd-event: ref event loop while in sd_event_prepare() ot sd_event_run() [8] (5)sd-event: refuse running default event loops in any other thread than the one they are default for [7] [Dropped-3]sd-event: let's suffix last_run/last_log with "_usec" [6] [Dropped-2]sd-event: fix delays assert brain-o (#17790) [5] (4)sd-event: split out code to add/remove timer event sources to earliest/latest prioq [4] (3)sd-event: split clock data allocation out of sd_event_add_time() [3] [Dropped-1]sd-event: mention that two debug logged events are ignored [2] (2)sd-event: split out enable and disable codepaths from sd_event_source_set_enabled() [1] (1)sd-event: split out helper functions for reshuffling prioqs I ported 10 of them back (from (1) to (10)) to fix this issue and dropped the other 6 (from [Dropped-1] to [Dropped-6]) for those reasons: [Dropped-1]Only changes error log. [Dropped-2]Fixes a bug introduced in a commit which doesn't exist in this version. [Dropped-3]Only changes vars' names and there is no functional change. [Dropped-4]More commits are needed for merging it, while I don't see any help on adding the rate-limiting ability. [Dropped-5]Change coding style for a function which isn't really used by anyone. [Dropped-6]Add test cases. Closes-Bug: #1924686 Signed-off-by: Li Zhou <li.zhou@windriver.com> Change-Id: Ia4c8f162cb1a47b40d1b26cf4d604976b97e92d6
107 lines
4.2 KiB
Diff
107 lines
4.2 KiB
Diff
From f72ca8a711fc406dc52f18c7dbc3bfc5397b26ea Mon Sep 17 00:00:00 2001
|
|
From: Lennart Poettering <lennart@poettering.net>
|
|
Date: Mon, 23 Nov 2020 17:49:27 +0100
|
|
Subject: [PATCH 13/20] sd-event: remove earliest_index/latest_index into
|
|
common part of event source objects
|
|
|
|
So far we used these fields to organize the earliest/latest timer event
|
|
priority queue. In a follow-up commit we want to introduce ratelimiting
|
|
to event sources, at which point we want any kind of event source to be
|
|
able to trigger time wakeups, and hence they all need to be included in
|
|
the earliest/latest prioqs. Thus, in preparation let's make this
|
|
generic.
|
|
|
|
No change in behaviour, just some shifting around of struct members from
|
|
the type-specific to the generic part.
|
|
|
|
(cherry picked from commit f41315fceb5208c496145cda2d6c865a5458ce44)
|
|
|
|
Related: #1819868
|
|
|
|
[commit 97f599bf57fdaee688ae5750e9b2b2587e2b597a from
|
|
https://github.com/systemd-rhel/rhel-8/]
|
|
|
|
Signed-off-by: Li Zhou <li.zhou@windriver.com>
|
|
---
|
|
src/libsystemd/sd-event/sd-event.c | 25 +++++++++++++------------
|
|
1 file changed, 13 insertions(+), 12 deletions(-)
|
|
|
|
diff --git a/src/libsystemd/sd-event/sd-event.c b/src/libsystemd/sd-event/sd-event.c
|
|
index a2f7868..82cb9ad 100644
|
|
--- a/src/libsystemd/sd-event/sd-event.c
|
|
+++ b/src/libsystemd/sd-event/sd-event.c
|
|
@@ -94,6 +94,9 @@ struct sd_event_source {
|
|
|
|
LIST_FIELDS(sd_event_source, sources);
|
|
|
|
+ unsigned earliest_index;
|
|
+ unsigned latest_index;
|
|
+
|
|
union {
|
|
struct {
|
|
sd_event_io_handler_t callback;
|
|
@@ -105,8 +108,6 @@ struct sd_event_source {
|
|
struct {
|
|
sd_event_time_handler_t callback;
|
|
usec_t next, accuracy;
|
|
- unsigned earliest_index;
|
|
- unsigned latest_index;
|
|
} time;
|
|
struct {
|
|
sd_event_signal_handler_t callback;
|
|
@@ -804,8 +805,8 @@ static void event_source_time_prioq_reshuffle(sd_event_source *s) {
|
|
/* Called whenever the event source's timer ordering properties changed, i.e. time, accuracy,
|
|
* pending, enable state. Makes sure the two prioq's are ordered properly again. */
|
|
assert_se(d = event_get_clock_data(s->event, s->type));
|
|
- prioq_reshuffle(d->earliest, s, &s->time.earliest_index);
|
|
- prioq_reshuffle(d->latest, s, &s->time.latest_index);
|
|
+ prioq_reshuffle(d->earliest, s, &s->earliest_index);
|
|
+ prioq_reshuffle(d->latest, s, &s->latest_index);
|
|
d->needs_rearm = true;
|
|
}
|
|
|
|
@@ -816,9 +817,9 @@ static void event_source_time_prioq_remove(
|
|
assert(s);
|
|
assert(d);
|
|
|
|
- prioq_remove(d->earliest, s, &s->time.earliest_index);
|
|
- prioq_remove(d->latest, s, &s->time.latest_index);
|
|
- s->time.earliest_index = s->time.latest_index = PRIOQ_IDX_NULL;
|
|
+ prioq_remove(d->earliest, s, &s->earliest_index);
|
|
+ prioq_remove(d->latest, s, &s->latest_index);
|
|
+ s->earliest_index = s->latest_index = PRIOQ_IDX_NULL;
|
|
d->needs_rearm = true;
|
|
}
|
|
|
|
@@ -1104,14 +1105,14 @@ static int event_source_time_prioq_put(
|
|
assert(s);
|
|
assert(d);
|
|
|
|
- r = prioq_put(d->earliest, s, &s->time.earliest_index);
|
|
+ r = prioq_put(d->earliest, s, &s->earliest_index);
|
|
if (r < 0)
|
|
return r;
|
|
|
|
- r = prioq_put(d->latest, s, &s->time.latest_index);
|
|
+ r = prioq_put(d->latest, s, &s->latest_index);
|
|
if (r < 0) {
|
|
- assert_se(prioq_remove(d->earliest, s, &s->time.earliest_index) > 0);
|
|
- s->time.earliest_index = PRIOQ_IDX_NULL;
|
|
+ assert_se(prioq_remove(d->earliest, s, &s->earliest_index) > 0);
|
|
+ s->earliest_index = PRIOQ_IDX_NULL;
|
|
return r;
|
|
}
|
|
|
|
@@ -1158,7 +1159,7 @@ _public_ int sd_event_add_time(
|
|
s->time.next = usec;
|
|
s->time.accuracy = accuracy == 0 ? DEFAULT_ACCURACY_USEC : accuracy;
|
|
s->time.callback = callback;
|
|
- s->time.earliest_index = s->time.latest_index = PRIOQ_IDX_NULL;
|
|
+ s->earliest_index = s->latest_index = PRIOQ_IDX_NULL;
|
|
s->userdata = userdata;
|
|
s->enabled = SD_EVENT_ONESHOT;
|
|
|
|
--
|
|
2.17.1
|
|
|