From 6ac67725b48cd2f115e135231add316fcf7ab9c3 Mon Sep 17 00:00:00 2001 From: sshathee Date: Mon, 13 Jan 2025 04:27:31 -0500 Subject: [PATCH] Improve deploy host state warning logging When state is "None", it doesn't have a value attribute. This commit handles null value and logs it accordingly. Test Plan: PASS: Unit test case with state value null PASS: Verify patch deploy and removal for pre-bootstrap case Task: 51543 Story: 2010676 Change-Id: Ib5fce886c5b88dcaecfe506a16b31b179a2e536d Signed-off-by: sshathee --- software/software/deploy_host_state.py | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/software/software/deploy_host_state.py b/software/software/deploy_host_state.py index fb381654..48423049 100644 --- a/software/software/deploy_host_state.py +++ b/software/software/deploy_host_state.py @@ -94,7 +94,8 @@ class DeployHostState(object): elif state in [DEPLOY_HOST_STATES.ROLLBACK_PENDING, DEPLOY_HOST_STATES.ROLLBACK_FAILED]: self.transform(DEPLOY_HOST_STATES.ROLLBACK_DEPLOYING) else: - LOG.warning("Unmapped host state transition: deploy_started from %s" % state.value) + LOG.warning("Unmapped host state transition: deploy_started from %s" % + (state.value if state else state)) def deployed(self): state = self.get_deploy_host_state() @@ -103,7 +104,8 @@ class DeployHostState(object): elif state == DEPLOY_HOST_STATES.ROLLBACK_DEPLOYING: self.transform(DEPLOY_HOST_STATES.ROLLBACK_DEPLOYED) else: - LOG.warning("Unmapped host state transition: deployed from %s" % state.value) + LOG.warning("Unmapped host state transition: deployed from %s" % + (state.value if state else state)) def deploy_failed(self): state = self.get_deploy_host_state() @@ -112,7 +114,8 @@ class DeployHostState(object): elif state == DEPLOY_HOST_STATES.ROLLBACK_DEPLOYING: self.transform(DEPLOY_HOST_STATES.ROLLBACK_FAILED) else: - LOG.warning("Unmapped host state transition: deploy_failed from %s" % state.value) + LOG.warning("Unmapped host state transition: deploy_failed from %s" % + (state.value if state else state)) def failed(self): """Transform deploy host state to failed without rollback logic."""