StarlingX Virtualization tools
Go to file
Thales Elero Cervi a4fad169ad libvirt: cherry-picks fix for qmp props param deprecation
After the QEMU uprev to be based on version 7.2+dfsg-7+deb12u5, while we
keep libvirt base version on 7.0.0-3 we are having an incompatibility
issue already reported usptream between qemu 6.0+ and libvirt <7.2 [1].
After version 6.0, qmp command 'object-add' does not support 'props'
parameter but libvirt 7.0.0-3 stills use it when assembling the
command [2-3].

This patch, then, brings the libvirt upstream commits that fixed this
issue starting from v7.2.0. While it is not possible to uprev our libvirt
this patch will be useful to fix the problem and enable proper
device attach when actions are performed on QEMU instances.

When we decide to uprev libvirt, this patch will no longer be needed.

[1] https://bugs.launchpad.net/starlingx/+bug/2078857
[2] https://bugzilla.redhat.com/show_bug.cgi?id=1958302
[3] https://bugzilla.redhat.com/show_bug.cgi?id=1944985

The list of upstream cherry-picked commits follows:

commit 1786cd4179fbaafe83f022c98fc6ee425177ceba
qemu: monitor: Don't add 'props' wrapper if qemu has QEMU_CAPS_OBJECT_QAPIFIED
Author: Peter Krempa <pkrempa@redhat.com>
Date:   Mon Nov 30 18:30:46 2020 +0100
Reviewed-by: Michal Privoznik <mprivozn@redhat.com>
(cherry picked from commit 96850dfe216f99019978a55027a1e763135ae88f)

commit 9f3a38f3adbdf5f68e960b9c70aa84543c8e7d57
qemuMonitorCreateObjectPropsWrap: Open-code in qemuBuildMemoryBackendProps
Author: Peter Krempa <pkrempa@redhat.com>
Date:   Mon Nov 30 17:08:46 2020 +0100
Reviewed-by: Michal Privoznik <mprivozn@redhat.com>
(cherry picked from commit 71828a7bc0646ef834af37509fa8300ef4e74340)

commit d2546ae335628e9589cae7c301c42f58772a6218
qemu: monitor: Make wrapping of 'props' of 'object-add' optional
Author: Peter Krempa <pkrempa@redhat.com>
Date:   Mon Nov 30 16:03:57 2020 +0100
Reviewed-by: Michal Privoznik <mprivozn@redhat.com>
(cherry picked from commit e0eeb2cc67d960a48937f99c659fb63dbd4049dc)

commit b545d8bf1a6ae4f651daa92a32fecc8819ee0a6c
qemu: capabilities: Introduce QEMU_CAPS_OBJECT_QAPIFIED
Author: Peter Krempa <pkrempa@redhat.com>
Date:   Fri Nov 27 07:06:13 2020 +0100
Reviewed-by: Michal Privoznik <mprivozn@redhat.com>
(cherry picked from commit 3d50ecc9bb2be88a56f00cd60335215b0d1132c2)

TEST PLAN:
PASS - build-pkgs -c -p libvirt
PASS - build-image stx-libvirt
PASS - Update a running AIO-DX stx-openstack deployment with the new
       image and ensure libvirt pods are updated and Running
PASS - Live-Migrate a running VM instance with a volume
PASS - Cold-Migrate a running VM instance with a volume

Closes-Bug: 2078857

Change-Id: I6dafafa220809c79f08420d181b2c4ef97f3b71b
Signed-off-by: Thales Elero Cervi <thaleselero.cervi@windriver.com>
2024-09-19 13:03:49 -03:00
doc sphinx: fix configuration 2023-10-30 10:15:14 -04:00
libvirt libvirt: cherry-picks fix for qmp props param deprecation 2024-09-19 13:03:49 -03:00
qemu Re-order DPDK args parsing in STX Patch 2024-08-28 18:20:16 +00:00
releasenotes/source Several fixes to get thing compiling correctly. 2023-04-12 16:40:19 -04:00
virt/libvirt-python Add debian package for virt/libvirt-python 2022-01-11 23:23:00 +00:00
.gitignore Initial zuul, tox, gitreview settup 2023-03-31 11:28:30 -04:00
.gitreview Initial zuul, tox, gitreview settup 2023-03-31 11:28:30 -04:00
.yamllint Initial zuul, tox, gitreview settup 2023-03-31 11:28:30 -04:00
.zuul.yaml Zuul/Tox: Fix stx-virt-pylint node set 2024-08-28 14:14:40 -03:00
centos_build_layer.cfg Several fixes to get thing compiling correctly. 2023-04-12 16:40:19 -04:00
centos_iso_image.inc Config file changes to add 'qemu libvirt ' after relocation from 'cgcs-root/stx/integ' 2023-03-31 10:56:45 -04:00
centos_pkg_dirs Config file changes to add 'qemu libvirt ' after relocation from 'cgcs-root/stx/integ' 2023-03-31 10:56:45 -04:00
centos_stable_docker_images.inc Update debian_stable_docker_images.inc to reflect libvirt relocation 2023-04-18 12:51:36 -04:00
debian_build_layer.cfg Several fixes to get thing compiling correctly. 2023-04-12 16:40:19 -04:00
debian_iso_image.inc Add missing qemu-utils package to Debian ISO 2023-04-20 15:52:42 -03:00
debian_pkg_dirs Config file changes to add 'qemu libvirt ' after relocation from 'cgcs-root/stx/integ' 2023-03-31 10:56:45 -04:00
debian_stable_docker_images.inc Update debian_stable_docker_images.inc to reflect libvirt relocation 2023-04-18 12:51:36 -04:00
LICENSE Initial zuul, tox, gitreview settup 2023-03-31 11:28:30 -04:00
README.rst Initial zuul, tox, gitreview settup 2023-03-31 11:28:30 -04:00
test-requirements.txt Several fixes to get thing compiling correctly. 2023-04-12 16:40:19 -04:00
tox.ini Several fixes to get thing compiling correctly. 2023-04-12 16:40:19 -04:00

virt

StarlingX Virtualization