x/vmware-nsx
Code Issues Proposed changes

NSXv3: Fix MAC Learning Profile POST API

Browse Source 
Per NSXv3 API MacManagementSwitchingProfile schema, the POST MAC
Learning switching profile API should use mac_change_allowed not
source_mac_change_allowed.

Also, the mac_change_allowed should not be used in creating MAC
Learning switching profile. That param is designed for used in ESX
to change MAC address once. In MAC Learning use case, as long as
mac_learning is enabled, mac_change_allowed doesn't matter.

Change-Id: Icd88f222c559c15949d9b9d1a600f78e89715bae
This commit is contained in:
Tong Liu 2016-10-06 06:11:41 +00:00
parent 71303b8a06
commit 875cf4a146
2 changed files with 1 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
vmware_nsx/nsxlib/v3/resources.py
View File

@ -160,8 +160,7 @@ class SwitchingProfile(AbstractRESTResource):
display_name=display_name,
description=description,
tags=tags or [],
mac_learning=mac_learning,
source_mac_change_allowed=True)
mac_learning=mac_learning)
def create_port_mirror_profile(self, display_name, description,
direction, destinations, tags=None):

1
vmware_nsx/tests/unit/nsxlib/v3/test_resources.py
View File

@ -182,7 +182,6 @@ class TestSwitchingProfileTestCase(nsxlib_testcase.NsxClientTestCase):
'display_name': 'plugin-mac-learning',
'description': 'mac-learning-for-plugin',
'tags': tags,
'source_mac_change_allowed': True,
}, sort_keys=True))
def test_find_by_display_name(self):