12362 Commits

Author SHA1 Message Date
Zuul
eab0625b20 Merge "Fix some unittests global issues" 2018-10-17 04:21:10 +00:00
Adit Sarfaty
c5ab00d5b5 NSX|V admin utils: Fix rpc method override
Admin utilities mock plugin should skip the RPC initialization.
This patch is fixing the name of hte overriding method.

Change-Id: I6bad63cf642a91c25fc6aaf53d0b91daa5179ab5
2018-10-16 09:57:16 +00:00
Adit Sarfaty
14c7fbb8ec NSX|V3: Add LB status calls validations
When getting the LB objects status and statistics from the NSX, verify the
structure ans content of the response, as sometimes it does not contain
all the data.

Change-Id: I4756daf688ebc29e5c71019ce28ae2df771e0b4c
2018-10-16 11:46:26 +03:00
Adit Sarfaty
2cbc02bc47 NSX|V fix LBaaS operation status function params
The plugin did not implement the LBaaS operation status for NSX-V
butthe function exists, and its params should match the one of the NSX-T
since the TVD plugin calls both.

Change-Id: I6dbe00d35739a751748a86f3856e229c58881fad
2018-10-16 11:22:19 +03:00
Zuul
91100ffd5a Merge "NSX|V3: Support security features for ENS switches" 2018-10-15 11:02:01 +00:00
Michal Kelner Mishali
0fd1424dda NSX-Policy: Support NSX policy in devstack
Code to support nsx policy in devstack

Change-Id: I41a702c69d8869475e4f6dc9009fd63e88b62a9e
Signed-off-by: Michal Kelner Mishali <mkelnermishal@vmware.com>
2018-10-15 08:44:03 +00:00
Adit Sarfaty
7270f8d9de NSX|P: remove sys usage from plugin
It causes problems at neutron init and is not really necessary

Change-Id: I320e45cc39a3c5506bf466c44a94f89c303d8088
2018-10-15 07:39:34 +00:00
Zuul
2b6c5d82ab Merge "Update .zuul.yaml" 2018-10-15 07:18:51 +00:00
Adit Sarfaty
563ed756bc Fix admin utils doc formatting
Change-Id: If6ca0f94cee81f6e01f98fae9d56a33a1575a576
2018-10-15 09:57:11 +03:00
Adit Sarfaty
2497f06add Fix some unittests global issues
1) Mock RPC calls in unittests
2) Remove duplicate dictionary key in one of the tests
3) Fix mock usage in one test to make pep8 happy

Change-Id: I6050a18c8188cacf776f98530e43f1455df805a0
2018-10-15 09:22:05 +03:00
Zuul
fdd8c2e47c Merge "NSX: moving devstack funcs to common" 2018-10-14 14:37:57 +00:00
Zuul
82be065b9d Merge "NSX|P: Initial connectivity support" 2018-10-14 14:34:47 +00:00
Andreas Jaeger
54bc5c0883 Update .zuul.yaml
Remove extra publish-openstack-python-branch-tarball job:

  With change https://review.openstack.org/609098 merged, we do not need
  required-projects for publish-openstack-python-branch-tarball anymore.

  The job can now be removed completely from the post pipeline since it
  is part of the python-jobs template.

Sort list of templates alphabetically to easily find them.

Remove job periodic-jobs-with-neutron-lib-master - this is a master only
job, it should stay in project-config to not confuse when branching.

Change-Id: Icd8838bab7c9ef288679b6b052e2702b71543571
2018-10-14 15:24:55 +02:00
Adit Sarfaty
25b37d5f5e NSX|V3 remove lbaas import to allow the plugin to work without lbaas
Replace LBaaS constants/classes with local ones or mocks to allow the
plugin to work without checking out the neutron-lbaas.

Change-Id: Iadf21ffcf7d4db8ab4e429b1daab2f8eccae1bc6
2018-10-14 11:03:21 +00:00
Zuul
5b5ff8b059 Merge "NSX|V Allow updating port security and mac learning together" 2018-10-14 08:51:48 +00:00
Anna Khmelnitsky
4f6730911c NSX|P: Initial connectivity support
Not covered yet: DHCP, Switching Profiles, TZs,
provider networks, GW, NAT

Change-Id: I9f4163d8a233b0d3914363556ddf6ec0f375f99a
2018-10-14 08:51:34 +00:00
Zuul
30e1395302 Merge "use retry_if_session_inactive from neutron-lib" 2018-10-14 07:54:54 +00:00
Adit Sarfaty
d328340faf NSX|V Allow updating port security and mac learning together
Change-Id: Ia3b4ade1f1500e2b8c6c51de5465a5cd1791a177
2018-10-14 08:17:26 +03:00
Zuul
bc3c910358 Merge "NSX|P: Policy pluging initial SG support" 2018-10-12 00:20:43 +00:00
Adit Sarfaty
2ba3f795a0 NSX|P: Policy pluging initial SG support
Initial support for security groups & rules for the NSX policy plugin

Change-Id: Ida67b34eaf01921aece261f7ad9446db53b0bfb4
2018-10-11 12:08:53 +00:00
Michal Kelner Mishali
dddfafd1b8 NSX: moving devstack funcs to common
Movinf functions that are both relevant to P and T
to common devstack script.

Change-Id: I3d502bd04b2486b5b27ebc29901bc40b33d991d0
Signed-off-by: Michal Kelner Mishali <mkelnermishal@vmware.com>
2018-10-11 14:18:48 +03:00
Adit Sarfaty
05d1805dcd NSX|V3: Change external provider network error message
Return a more significant error message on the attempt to create an
external provider network.

Change-Id: Ie6da32acda066691397a96ffa12a2df631f3dadd
2018-10-11 10:03:52 +00:00
Adit Sarfaty
b7c6bb0db6 NSX|V: Improve SG rule service creation
1. Translate unsupported protocols names to their IP protocol number to
allow the rule to be created on the NSX
2. Check if this protocl is allowed for port-rrange-max/min
3. reraise the NSX error in case of failure (for bad icmp type/codes
errors for example)

Change-Id: I33e7ee9b85a793083d36b00384a2f0492898691d
2018-10-11 08:30:53 +00:00
Adit Sarfaty
e86f7a1af5 Skip Octavia init in UT
Some UT get stuck becasue of conflicts with the Octavia RPC

Change-Id: I209b7f38b5317d1158b9046e7f77e0619d3e5818
2018-10-11 09:32:30 +03:00
Zuul
9c7991dacb Merge "TVD: Octavia support" 2018-10-10 19:43:42 +00:00
Zuul
dc443e1a51 Merge "Remove release pipeline" 2018-10-10 15:02:52 +00:00
Adit Sarfaty
45ca00ea62 NSX|V3: remove redundent DB calls for floatingips
When extending port dict, there is no need to get the nsx LS ID from
the DB for floatingips since they belong to an external network.

Change-Id: Iea423fd467b1020416e3219e3cf34fc5144dde10
2018-10-10 11:15:42 +00:00
Adit Sarfaty
eb2869fe03 TVD: Octavia support
For the TVD plugin, the Octavia listener will use a wrapper and select
the T/V implementation by the loadbalancer project

Change-Id: I0540f7998e72b73058fd531f2fb16364b4f35491
2018-10-10 08:44:43 +03:00
Andreas Jaeger
e2c6bce350 Remove release pipeline
release jobs need to stay in project-config, they will not work in-repo
as expected. Remove them.

See also
https://docs.openstack.org/infra/manual/creators.html#central-config-exceptions

Change-Id: I2fc0fd299dfcfa18b9142237e656323a4ed77bc0
2018-10-10 04:58:19 +00:00
Adit Sarfaty
e8caffa307 NSX|V3: Support security features for ENS switches
Depending on the platform version, support port-security, and allow
disabling mac learning for ENS netowrks and ports.

Change-Id: I412c30aa87a7706603696ddff476ac58600d7b87
2018-10-09 10:18:02 +00:00
Zuul
2dea64def5 Merge "NSX|V+V3: Octavia driver" 2018-10-07 09:25:57 +00:00
Zuul
98de6872d7 Merge "NSX|V: Fix BGP plugin get operations" 2018-10-07 07:56:50 +00:00
Boden R
7bcac8c261 use retry_if_session_inactive from neutron-lib
The retry_if_session_inactive decorator was rehomed into neutron-lib
[1]. This patch consumes it by using neutron-libs version where
appropriate in prep for [2].

[1] https://review.openstack.org/#/c/557040/
[2] https://review.openstack.org/#/c/607710/

Change-Id: I32905d95fe216d6113ff6b82de17aae650d0d736
2018-10-05 06:07:22 -06:00
Adit Sarfaty
4333da8216 NSX|V: Fix BGP plugin get operations
The TVD integration for the BGP plugin tried to filter get results
based on the plugin type.
Since the same plugin is also used for the V plugin, it failed.
This patch removes this filtering code since BGP is currently supported
only by the NSX-V anyway.

Change-Id: I20ef5e1763cab28b1e12b03a75e24bbf50f394dc
2018-10-04 09:36:39 +00:00
Adit Sarfaty
48004c8806 NSX|V+V3: Prevent adding different projects routers to fwaas-V1
When a user tries to add a router from 1 project to a FW from another,
the driver should through InternalDriverError for hte FW to be in ERROR state.
This should not be done in case of a delete action, in order to allow
the deletion of an ERROR FW as well.

Commit Ia86ccc7906ff58b35dccb01f4c165822b9dbf2a9 removed the InternalDriverError
in a wrong attempt to handle the deletion case.

Change-Id: I2c88c6ff773235876253a0b194d30d1d417e03c4
2018-10-04 12:02:41 +03:00
Zuul
c2e38a3d28 Merge "add py36 jobs and tox target" 2018-10-04 06:42:26 +00:00
Boden R
822f7c4cf7 add py36 jobs and tox target
As part of the python 3 first effort [1], this patch adds UT support for
python 3.6 by:
- Updating the zuul.yaml to include the py36 template and jobs.
- Adding a py36-dev target to tox.ini for local testing.
- Updating the upper constraints to use master rather than stable/rocky.
- Updating the version of eventlet used as previous 2x.x versions had
a python 3 bug for monkey patching.
- Consolidating the eventlet monkey patching in the code.

[1] https://governance.openstack.org/tc/goals/stein/python3-first.html

Change-Id: I3c11ac9dff9a2e25b33e8310929c961ffd0bcc52
2018-10-02 08:23:08 -06:00
Adit Sarfaty
4edec4ab9b NSX|P: Use nsx_p certificate configuration
When initializing the NSX policy connection, the nsx_p configuration
should be used for the certificate parameters.

Change-Id: I2a103930d2a378b267a3cc7320cdd2f37a59a1bb
2018-10-02 12:28:44 +03:00
Kobi Samoray
83d9b3abdd NSX|V+V3: Octavia driver
Implementing the Octavia support for NSX-V & NSX-T.
Follow up patches will handle the TVD plugin, Status updates,
and migration.

Since Octavia is not (yet?) in the requirements, using a hack to allow unittests
to be skipped.

Co-Authored-by: Adit Sarfaty <asarfaty@vmware.com>
Change-Id: Iadb24e7eadcab658faf3e646cc528c2a8a6976e5
2018-10-02 11:19:55 +03:00
Andreas Jaeger
759f015542 use openstack-tox-docs job
With the new job, we do not need all the required-projects. thus, use
the new job openstack-tox-docs instead of build-openstack-sphinx-docs.

Change-Id: I8e36eb528d22b8d61d2f6ee77d271fc143e71314
2018-09-28 12:49:09 +02:00
Andreas Jaeger
c7c6484f9f Remove templates that will not work here
periodic-stable-jobs-neutron runs only on stable branches and needs to
stay in project-config.

The job publish-to-pypi-neutron needs to stay in project-config as well
to trigger on releases.

Change-Id: Ib9b38b17cbb1b91a599a9d34927b554b4880fd09
2018-09-28 12:39:57 +02:00
Zuul
188b5802f0 Merge "Refactor provider SG validation" 2018-09-27 16:41:34 +00:00
Zuul
88ce1540d8 Merge "opt in for neutron-lib consumption patches" 2018-09-27 13:35:16 +00:00
Adit Sarfaty
37be04703a Refactor provider SG validation
- Prevent non-admin user from changing a provider SG (in addition to delete,
add rule & delete rule which were already prevented)
- rename the validation method and error
(please note - preventing SG creation is done with a policy.json rule)

Change-Id: Idcd1c6c7082b1bd26d0fbc19a399e01ecbf2fb0f
2018-09-27 10:33:21 +00:00
Zuul
bfcd1c9414 Merge "use common rpc and exceptions from neutron-lib" 2018-09-27 10:08:56 +00:00
Boden R
776fced845 move per branch zuul config into repo
This is part of the python 3 workstream [1] and moves the per branch
zuul config into to vmware-nsx repo. The periodic and periodic-stable
jobs will stay in project config.

[1] https://governance.openstack.org/tc/goals/stein/python3-first.html

Change-Id: Ie4ebc4b33c08274acd9dc019b58989989396b6c5
2018-09-27 06:43:47 +00:00
Boden R
a482824e20 opt in for neutron-lib consumption patches
As part of the Denver PTG [1] we decided networking related projects
that are "current" and want to receive neutron-lib consumption patches
on an on-going basis should indicate such with a well defined comment
in their requirements.txt. This allows us to easily find the list of
project to receive neutron-lib consumption patches [2] by searching for
the string.

In addition, projects opting-in for these patches are also attesting
they will stay up to date with TC and infra initiatives to ensure
consumption patches can flow freely.

This patch adds the "neutron-lib-current" string to requirements.txt
opting in for neutron-lib consumption patches.

[1] https://etherpad.openstack.org/p/neutron-stein-ptg
[2] https://docs.openstack.org/neutron-lib/latest/contributor/contributing.html#phase-4-consume

Change-Id: I5bb8de0b7a62043c71010b737bc1d21e7454e4f7
2018-09-27 06:43:30 +00:00
Boden R
ee46527c9c use common rpc and exceptions from neutron-lib
The neutron.common.rpc and exceptions were rehomed into neutron-lib and
are currently shimmed in neutron [1]

This patch consumes those modules from neutron-lib by using lib's
modules rather than neutrons.

[1] https://review.openstack.org/#/c/586525/

Change-Id: I18a697f1f2d8ddbd203f4435b4aab92a8b045a44
2018-09-27 06:42:45 +00:00
Adit Sarfaty
01f5a1c7b7 Adjust router notification test
Commit I01ced41201b61c624e675375b7bcd9589b2553e0 added a unit test
which needs to be adjusted to the vmware-nsx plugins, mainly becasue
the plugins do not support changing the external network flag.

Change-Id: Ibbadb81c658bf81165899e35ba55204485ab86b8
2018-09-26 17:08:31 +03:00
Zuul
f42842013b Merge "NSX|V: Validate DVS Id when creating flat/vlan network" 2018-09-24 09:48:33 +00:00