28c14f567e
As bug 1568706 uncovered, we were using zuul-cloner in our gate jobs; this was preventing our translation from syncing. After digging into this issue a number of changes in this associated logic were found to not be in sync with neutron. This patch updates out tox/tools logic to follow that of neutron. In addition this patch fixes any pylint checks that were failing to make pep8 pass. IMPORTANT: Please review closely, not only to the tools/tox updates but also to the ignored pylint checks in the code. We only want to disable checks where appropriate. Change-Id: I6c5fee3ca3073ad079eac1636cc3b9ec45926a68 Closes-Bug: #1568706
84 lines
2.8 KiB
Bash
Executable File
84 lines
2.8 KiB
Bash
Executable File
#! /bin/sh
|
|
|
|
# Copyright (C) 2014 VA Linux Systems Japan K.K.
|
|
# Copyright (C) 2014 YAMAMOTO Takashi <yamamoto at valinux co jp>
|
|
# All Rights Reserved.
|
|
#
|
|
# Licensed under the Apache License, Version 2.0 (the "License"); you may
|
|
# not use this file except in compliance with the License. You may obtain
|
|
# a copy of the License at
|
|
#
|
|
# http://www.apache.org/licenses/LICENSE-2.0
|
|
#
|
|
# Unless required by applicable law or agreed to in writing, software
|
|
# distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
|
|
# WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
|
|
# License for the specific language governing permissions and limitations
|
|
# under the License.
|
|
|
|
TMPDIR=`mktemp -d /tmp/${0##*/}.XXXXXX` || exit 1
|
|
export TMPDIR
|
|
trap "rm -rf $TMPDIR" EXIT
|
|
|
|
FAILURES=$TMPDIR/failures
|
|
|
|
|
|
check_no_symlinks_allowed () {
|
|
# Symlinks break the package build process, so ensure that they
|
|
# do not slip in, except hidden symlinks.
|
|
if [ $(find . -type l ! -path '*/.*' | wc -l) -ge 1 ]; then
|
|
echo "Symlinks are not allowed!" >>$FAILURES
|
|
fi
|
|
}
|
|
|
|
|
|
check_pot_files_errors () {
|
|
# The job vmware-nsx-propose-translation-update does not update from
|
|
# transifex since our po files contain duplicate entries where
|
|
# obsolete entries duplicate normal entries. Prevent obsolete
|
|
# entries to slip in
|
|
if [ $(find vmware_nsx -type f -regex '.*\.pot?' | wc -l) -ge 1 ]; then
|
|
find vmware_nsx -type f -regex '.*\.pot?' \
|
|
-print0|xargs -0 -n 1 msgfmt --check-format \
|
|
-o /dev/null
|
|
if [ "$?" -ne 0 ]; then
|
|
echo "PO files syntax is not correct!" >>$FAILURES
|
|
fi
|
|
fi
|
|
}
|
|
|
|
|
|
check_identical_policy_files () {
|
|
# For unit tests, we maintain their own policy.json file to make test suite
|
|
# independent of whether it's executed from the vmware-nsx source tree or from
|
|
# site-packages installation path. We don't want two copies of the same
|
|
# file to diverge, so checking that they are identical
|
|
diff etc/policy.json vmware-nsx/tests/etc/policy.json 2>&1 > /dev/null
|
|
if [ "$?" -ne 0 ]; then
|
|
echo "policy.json files must be identical!" >>$FAILURES
|
|
fi
|
|
}
|
|
|
|
check_no_duplicate_api_test_idempotent_ids() {
|
|
# For API tests, an idempotent ID is assigned to each single API test,
|
|
# those IDs should be unique
|
|
output=$(check-uuid --package vmware_nsx_tempest)
|
|
if [ "$?" -ne 0 ]; then
|
|
echo "There are duplicate idempotent ids in the API tests" >>$FAILURES
|
|
echo "please, assign unique uuids to each API test:" >>$FAILURES
|
|
echo "$output" >>$FAILURES
|
|
fi
|
|
}
|
|
|
|
# Add your checks here...
|
|
check_no_symlinks_allowed
|
|
check_pot_files_errors
|
|
#check_identical_policy_files
|
|
check_no_duplicate_api_test_idempotent_ids
|
|
|
|
# Fail, if there are emitted failures
|
|
if [ -f $FAILURES ]; then
|
|
cat $FAILURES
|
|
exit 1
|
|
fi
|