3ba085fec3
Expose firewall rule rule_tag property. Change-Id: Iec6848e325bb7e1eb43b83d060ba9486897cc93a
633 lines
25 KiB
Python
633 lines
25 KiB
Python
# Copyright 2015 OpenStack Foundation
|
|
|
|
# All Rights Reserved
|
|
#
|
|
# Licensed under the Apache License, Version 2.0 (the "License"); you may
|
|
# not use this file except in compliance with the License. You may obtain
|
|
# a copy of the License at
|
|
#
|
|
# http://www.apache.org/licenses/LICENSE-2.0
|
|
#
|
|
# Unless required by applicable law or agreed to in writing, software
|
|
# distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
|
|
# WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
|
|
# License for the specific language governing permissions and limitations
|
|
# under the License.
|
|
|
|
"""
|
|
NSX-V3 Plugin security & Distributed Firewall integration module
|
|
"""
|
|
|
|
from distutils import version
|
|
|
|
from oslo_log import log
|
|
from oslo_utils import excutils
|
|
|
|
from vmware_nsxlib.v3 import exceptions
|
|
from vmware_nsxlib.v3 import nsx_constants as consts
|
|
from vmware_nsxlib.v3 import utils
|
|
|
|
|
|
LOG = log.getLogger(__name__)
|
|
|
|
PORT_SG_SCOPE = 'os-security-group'
|
|
|
|
|
|
class NsxLibNsGroup(utils.NsxLibApiBase):
|
|
|
|
def __init__(self, client, nsxlib_config, firewall_section_handler,
|
|
nsxlib=None):
|
|
self.firewall_section = firewall_section_handler
|
|
super(NsxLibNsGroup, self).__init__(client, nsxlib_config,
|
|
nsxlib=nsxlib)
|
|
|
|
@property
|
|
def uri_segment(self):
|
|
return 'ns-groups'
|
|
|
|
@property
|
|
def resource_type(self):
|
|
return 'NSGroup'
|
|
|
|
def update_nsgroup_and_section(self, name, description, logging,
|
|
nsgroup_id, section_id,
|
|
log_sg_allowed_traffic):
|
|
logging = (log_sg_allowed_traffic or logging)
|
|
rules = self.firewall_section._process_rules_logging_for_update(
|
|
section_id, logging)
|
|
self.update(nsgroup_id, name, description)
|
|
self.firewall_section.update(section_id, name, description,
|
|
rules=rules)
|
|
|
|
def update_lport_nsgroups(self, lport_id, original_nsgroups,
|
|
updated_nsgroups):
|
|
"""Update the NSgroups that the logical ports belongs to"""
|
|
added = set(updated_nsgroups) - set(original_nsgroups)
|
|
removed = set(original_nsgroups) - set(updated_nsgroups)
|
|
for nsgroup_id in added:
|
|
try:
|
|
self.add_members(
|
|
nsgroup_id, consts.TARGET_TYPE_LOGICAL_PORT,
|
|
[lport_id])
|
|
except exceptions.NSGroupIsFull:
|
|
for nsgroup_id in added:
|
|
# NOTE(roeyc): If the port was not added to the nsgroup
|
|
# yet, then this request will silently fail.
|
|
self.remove_member(
|
|
nsgroup_id, consts.TARGET_TYPE_LOGICAL_PORT,
|
|
lport_id)
|
|
raise exceptions.SecurityGroupMaximumCapacityReached(
|
|
sg_id=nsgroup_id)
|
|
except exceptions.ResourceNotFound:
|
|
with excutils.save_and_reraise_exception():
|
|
LOG.error("NSGroup %s doesn't exists", nsgroup_id)
|
|
for nsgroup_id in removed:
|
|
self.remove_member(
|
|
nsgroup_id, consts.TARGET_TYPE_LOGICAL_PORT, lport_id)
|
|
|
|
def get_nsservice(self, resource_type, **properties):
|
|
service = {'resource_type': resource_type}
|
|
service.update(properties)
|
|
return {'service': service}
|
|
|
|
def get_nsgroup_complex_expression(self, expressions):
|
|
return {'resource_type': consts.NSGROUP_COMPLEX_EXP,
|
|
'expressions': expressions}
|
|
|
|
def get_switch_tag_expression(self, scope, tag):
|
|
return {'resource_type': consts.NSGROUP_TAG_EXP,
|
|
'target_type': consts.TARGET_TYPE_LOGICAL_SWITCH,
|
|
'scope': scope,
|
|
'tag': tag}
|
|
|
|
def get_port_tag_expression(self, scope, tag):
|
|
return {'resource_type': consts.NSGROUP_TAG_EXP,
|
|
'target_type': consts.TARGET_TYPE_LOGICAL_PORT,
|
|
'scope': scope,
|
|
'tag': tag}
|
|
|
|
def create(self, display_name, description, tags,
|
|
membership_criteria=None, members=None):
|
|
body = {'display_name': display_name,
|
|
'description': description,
|
|
'tags': tags,
|
|
'members': [] if members is None else members}
|
|
if membership_criteria:
|
|
# Allow caller to pass a list of membership criterias.
|
|
# The 'else' block is maintained for backwards compatibility
|
|
# where in a caller might only send a single membership criteria.
|
|
if isinstance(membership_criteria, list):
|
|
body.update({'membership_criteria': membership_criteria})
|
|
else:
|
|
body.update({'membership_criteria': [membership_criteria]})
|
|
return self.client.create(self.get_path(), body)
|
|
|
|
def list(self):
|
|
return self.client.list(
|
|
'%s?populate_references=false' % self.get_path()).get(
|
|
'results', [])
|
|
|
|
def update(self, nsgroup_id, display_name=None, description=None,
|
|
membership_criteria=None, members=None, tags_update=None):
|
|
nsgroup = {}
|
|
if display_name is not None:
|
|
nsgroup['display_name'] = display_name
|
|
if description is not None:
|
|
nsgroup['description'] = description
|
|
if members is not None:
|
|
nsgroup['members'] = members
|
|
if membership_criteria is not None:
|
|
if isinstance(membership_criteria, list):
|
|
nsgroup['membership_criteria'] = membership_criteria
|
|
else:
|
|
nsgroup['membership_criteria'] = [membership_criteria]
|
|
if tags_update is not None:
|
|
nsgroup['tags_update'] = tags_update
|
|
return self._update_resource(
|
|
self.get_path(nsgroup_id), nsgroup,
|
|
get_params='?populate_references=true',
|
|
retry=True)
|
|
|
|
def get_member_expression(self, target_type, target_id):
|
|
return {
|
|
'resource_type': consts.NSGROUP_SIMPLE_EXP,
|
|
'target_property': 'id',
|
|
'target_type': target_type,
|
|
'op': consts.EQUALS,
|
|
'value': target_id}
|
|
|
|
def _update_with_members(self, nsgroup_id, members, action):
|
|
members_update = '%s?action=%s' % (self.get_path(nsgroup_id), action)
|
|
return self.client.create(members_update, members)
|
|
|
|
def add_members(self, nsgroup_id, target_type, target_ids):
|
|
members = []
|
|
for target_id in target_ids:
|
|
member_expr = self.get_member_expression(
|
|
target_type, target_id)
|
|
members.append(member_expr)
|
|
members = {'members': members}
|
|
try:
|
|
return self._update_with_members(
|
|
nsgroup_id, members, consts.NSGROUP_ADD_MEMBERS)
|
|
except (exceptions.StaleRevision, exceptions.ResourceNotFound):
|
|
raise
|
|
except exceptions.ManagerError:
|
|
# REVISIT(roeyc): A ManagerError might have been raised for a
|
|
# different reason, e.g - NSGroup does not exists.
|
|
LOG.warning("Failed to add %(target_type)s resources "
|
|
"(%(target_ids)s) to NSGroup %(nsgroup_id)s",
|
|
{'target_type': target_type,
|
|
'target_ids': target_ids,
|
|
'nsgroup_id': nsgroup_id})
|
|
|
|
raise exceptions.NSGroupIsFull(nsgroup_id=nsgroup_id)
|
|
|
|
def remove_member(self, nsgroup_id, target_type,
|
|
target_id, verify=False):
|
|
member_expr = self.get_member_expression(
|
|
target_type, target_id)
|
|
members = {'members': [member_expr]}
|
|
try:
|
|
return self._update_with_members(
|
|
nsgroup_id, members, consts.NSGROUP_REMOVE_MEMBERS)
|
|
except exceptions.ManagerError:
|
|
if verify:
|
|
raise exceptions.NSGroupMemberNotFound(member_id=target_id,
|
|
nsgroup_id=nsgroup_id)
|
|
|
|
def read(self, nsgroup_id):
|
|
return self.client.get(
|
|
'%s?populate_references=true' % self.get_path(nsgroup_id))
|
|
|
|
def delete(self, nsgroup_id):
|
|
resource = '%s?force=true' % nsgroup_id
|
|
return self._delete_with_retry(resource)
|
|
|
|
def find_by_display_name(self, display_name):
|
|
found = []
|
|
for resource in self.list():
|
|
if resource['display_name'] == display_name:
|
|
found.append(resource)
|
|
return found
|
|
|
|
|
|
class NsxLibFirewallSection(utils.NsxLibApiBase):
|
|
|
|
@property
|
|
def uri_segment(self):
|
|
return 'firewall/sections'
|
|
|
|
@property
|
|
def resource_type(self):
|
|
return 'FirewallSection'
|
|
|
|
def add_member_to_fw_exclude_list(self, target_id, target_type):
|
|
resource = 'firewall/excludelist?action=add_member'
|
|
body = {"target_id": target_id,
|
|
"target_type": target_type}
|
|
self._create_with_retry(resource, body)
|
|
|
|
def remove_member_from_fw_exclude_list(self, target_id, target_type):
|
|
resource = ('firewall/excludelist?action=remove_member&object_id=' +
|
|
target_id)
|
|
self._create_with_retry(resource)
|
|
|
|
def get_excludelist(self):
|
|
return self.client.list('firewall/excludelist')
|
|
|
|
def _get_direction(self, sg_rule):
|
|
return (
|
|
consts.IN if sg_rule['direction'] == 'ingress'
|
|
else consts.OUT
|
|
)
|
|
|
|
def get_nsservice(self, resource_type, **properties):
|
|
service = {'resource_type': resource_type}
|
|
service.update(properties)
|
|
return {'service': service}
|
|
|
|
def _decide_service(self, sg_rule):
|
|
l4_protocol = utils.get_l4_protocol_name(sg_rule['protocol'])
|
|
|
|
if l4_protocol in [consts.TCP, consts.UDP]:
|
|
# If port_range_min is not specified then we assume all ports are
|
|
# matched, relying on neutron to perform validation.
|
|
if sg_rule['port_range_min'] is None:
|
|
destination_ports = []
|
|
elif sg_rule['port_range_min'] != sg_rule['port_range_max']:
|
|
# NSX API requires a non-empty range (e.g - '22-23')
|
|
destination_ports = ['%(port_range_min)s-%(port_range_max)s'
|
|
% sg_rule]
|
|
else:
|
|
destination_ports = ['%(port_range_min)s' % sg_rule]
|
|
|
|
return self.get_nsservice(
|
|
consts.L4_PORT_SET_NSSERVICE,
|
|
l4_protocol=l4_protocol,
|
|
source_ports=[],
|
|
destination_ports=destination_ports)
|
|
elif l4_protocol == consts.ICMPV4:
|
|
# Validate the icmp type & code
|
|
icmp_type = sg_rule['port_range_min']
|
|
icmp_code = sg_rule['port_range_max']
|
|
icmp_strict = self.nsxlib.feature_supported(
|
|
consts.FEATURE_ICMP_STRICT)
|
|
utils.validate_icmp_params(icmp_type, icmp_code, icmp_version=4,
|
|
strict=icmp_strict)
|
|
|
|
return self.get_nsservice(
|
|
consts.ICMP_TYPE_NSSERVICE,
|
|
protocol=l4_protocol,
|
|
icmp_type=icmp_type,
|
|
icmp_code=icmp_code)
|
|
elif l4_protocol is not None:
|
|
return self.get_nsservice(
|
|
consts.IP_PROTOCOL_NSSERVICE,
|
|
protocol_number=l4_protocol)
|
|
|
|
def _build(self, display_name, description, applied_tos, tags):
|
|
return {'display_name': display_name,
|
|
'description': description,
|
|
'stateful': True,
|
|
'section_type': consts.FW_SECTION_LAYER3,
|
|
'applied_tos': [self.get_nsgroup_reference(t_id)
|
|
for t_id in applied_tos],
|
|
'tags': tags}
|
|
|
|
def create_empty(self, display_name, description,
|
|
applied_tos, tags,
|
|
operation=consts.FW_INSERT_BOTTOM,
|
|
other_section=None):
|
|
resource = '%s?operation=%s' % (self.uri_segment, operation)
|
|
body = self._build(display_name, description,
|
|
applied_tos, tags)
|
|
if other_section:
|
|
resource += '&id=%s' % other_section
|
|
return self._create_with_retry(resource, body)
|
|
|
|
def create_with_rules(self, display_name, description, applied_tos=None,
|
|
tags=None, operation=consts.FW_INSERT_BOTTOM,
|
|
other_section=None, rules=None):
|
|
resource = '%s?operation=%s' % (self.uri_segment, operation)
|
|
body = {
|
|
'display_name': display_name,
|
|
'description': description,
|
|
'stateful': True,
|
|
'section_type': consts.FW_SECTION_LAYER3,
|
|
'applied_tos': applied_tos or [],
|
|
'tags': tags or []
|
|
}
|
|
if rules is not None:
|
|
resource += '&action=create_with_rules'
|
|
body['rules'] = rules
|
|
if other_section:
|
|
resource += '&id=%s' % other_section
|
|
return self._create_with_retry(resource, body)
|
|
|
|
def update(self, section_id, display_name=None, description=None,
|
|
applied_tos=None, rules=None, tags_update=None, force=False):
|
|
resource = self.get_path(section_id)
|
|
params = None
|
|
section = {}
|
|
if rules is not None:
|
|
params = '?action=update_with_rules'
|
|
section['rules'] = rules
|
|
if display_name is not None:
|
|
section['display_name'] = display_name
|
|
if description is not None:
|
|
section['description'] = description
|
|
if applied_tos is not None:
|
|
section['applied_tos'] = [self.get_nsgroup_reference(nsg_id)
|
|
for nsg_id in applied_tos]
|
|
if tags_update is not None:
|
|
section['tags_update'] = tags_update
|
|
|
|
headers = None
|
|
if force:
|
|
# shared sections (like default section) can serve multiple
|
|
# openstack deployments. If some operate under protected
|
|
# identities, force-overwrite is needed.
|
|
# REVISIT(annak): find better solution for shared sections
|
|
headers = {'X-Allow-Overwrite': 'true'}
|
|
|
|
if rules is not None:
|
|
return self._update_resource(resource, section,
|
|
headers=headers,
|
|
create_action=True,
|
|
action_params=params,
|
|
retry=True)
|
|
|
|
elif any(p is not None for p in (display_name, description,
|
|
applied_tos, tags_update)):
|
|
return self._update_resource(resource, section,
|
|
headers=headers,
|
|
action_params=params,
|
|
retry=True)
|
|
|
|
def list(self):
|
|
return self.client.list(self.get_path()).get('results', [])
|
|
|
|
def delete(self, section_id):
|
|
resource = '%s?cascade=true' % section_id
|
|
return self._delete_with_retry(resource)
|
|
|
|
def get_nsgroup_reference(self, nsgroup_id):
|
|
return {'target_id': nsgroup_id,
|
|
'target_type': consts.NSGROUP}
|
|
|
|
def get_logicalport_reference(self, port_id):
|
|
return {'target_id': port_id,
|
|
'target_type': consts.TARGET_TYPE_LOGICAL_PORT}
|
|
|
|
def get_ip_cidr_reference(self, ip_cidr_block, ip_protocol):
|
|
target_type = (consts.TARGET_TYPE_IPV4ADDRESS
|
|
if ip_protocol == consts.IPV4
|
|
else consts.TARGET_TYPE_IPV6ADDRESS)
|
|
return {'target_id': ip_cidr_block,
|
|
'target_type': target_type}
|
|
|
|
def get_rule_address(self, target_id, display_name=None, is_valid=True,
|
|
target_type=consts.TARGET_TYPE_IPV4ADDRESS):
|
|
return {'target_display_name': display_name or '',
|
|
'target_id': target_id,
|
|
'is_valid': is_valid,
|
|
'target_type': target_type}
|
|
|
|
def get_l4portset_nsservice(self, sources=None, destinations=None,
|
|
protocol=consts.TCP):
|
|
return {
|
|
'service': {
|
|
'resource_type': 'L4PortSetNSService',
|
|
'source_ports': sources or [],
|
|
'destination_ports': destinations or [],
|
|
'l4_protocol': protocol}
|
|
}
|
|
|
|
def get_rule_dict(self, display_name, sources=None, destinations=None,
|
|
direction=consts.IN_OUT, ip_protocol=consts.IPV4_IPV6,
|
|
services=None, action=consts.FW_ACTION_ALLOW,
|
|
logged=False, disabled=False, applied_tos=None,
|
|
rule_tag=None):
|
|
rule_dict = {'display_name': display_name,
|
|
'direction': direction,
|
|
'ip_protocol': ip_protocol,
|
|
'action': action,
|
|
'logged': logged,
|
|
'disabled': disabled,
|
|
'sources': sources or [],
|
|
'destinations': destinations or [],
|
|
'services': services or []}
|
|
if applied_tos is not None:
|
|
rule_dict['applied_tos'] = applied_tos
|
|
if rule_tag is not None:
|
|
rule_dict['rule_tag'] = rule_tag
|
|
return rule_dict
|
|
|
|
def add_rule(self, rule, section_id, operation=consts.FW_INSERT_BOTTOM):
|
|
@utils.retry_upon_exception(exceptions.StaleRevision,
|
|
max_attempts=self.client.max_attempts)
|
|
def _do_add_rule():
|
|
resource = '%s/rules' % self.get_path(section_id)
|
|
params = '?operation=%s' % operation
|
|
if (version.LooseVersion(self.nsxlib.get_version()) >=
|
|
version.LooseVersion(consts.NSX_VERSION_2_4_0)):
|
|
rule['_revision'] = self.get(section_id)['_revision']
|
|
return self.client.create(resource + params, rule)
|
|
return _do_add_rule()
|
|
|
|
def add_rules(self, rules, section_id, operation=consts.FW_INSERT_BOTTOM):
|
|
@utils.retry_upon_exception(exceptions.StaleRevision,
|
|
max_attempts=self.client.max_attempts)
|
|
def _do_add_rules():
|
|
resource = '%s/rules' % self.get_path(section_id)
|
|
params = '?action=create_multiple&operation=%s' % operation
|
|
if (version.LooseVersion(self.nsxlib.get_version()) >=
|
|
version.LooseVersion(consts.NSX_VERSION_2_4_0)):
|
|
rev_id = self.get(section_id)['_revision']
|
|
for rule in rules:
|
|
rule['_revision'] = rev_id
|
|
return self.client.create(resource + params, {'rules': rules})
|
|
return _do_add_rules()
|
|
|
|
def delete_rule(self, section_id, rule_id):
|
|
resource = '%s/rules/%s' % (section_id, rule_id)
|
|
return self._delete_with_retry(resource)
|
|
|
|
def get_rules(self, section_id):
|
|
resource = '%s/rules' % self.get_path(section_id)
|
|
return self.client.get(resource)
|
|
|
|
def get_default_rule(self, section_id):
|
|
rules = self.get_rules(section_id)['results']
|
|
last_rule = rules[-1]
|
|
if last_rule['is_default']:
|
|
return last_rule
|
|
|
|
def _get_fw_rule_from_sg_rule(self, sg_rule, nsgroup_id, rmt_nsgroup_id,
|
|
logged, action):
|
|
# IPV4 or IPV6
|
|
ip_protocol = sg_rule['ethertype'].upper()
|
|
direction = self._get_direction(sg_rule)
|
|
|
|
if sg_rule.get(consts.LOCAL_IP_PREFIX):
|
|
local_ip_prefix = self.get_ip_cidr_reference(
|
|
sg_rule[consts.LOCAL_IP_PREFIX],
|
|
ip_protocol)
|
|
else:
|
|
local_ip_prefix = None
|
|
|
|
source = None
|
|
local_group = self.get_nsgroup_reference(nsgroup_id)
|
|
if sg_rule['remote_ip_prefix'] is not None:
|
|
source = self.get_ip_cidr_reference(
|
|
sg_rule['remote_ip_prefix'], ip_protocol)
|
|
destination = local_ip_prefix or local_group
|
|
else:
|
|
if rmt_nsgroup_id:
|
|
source = self.get_nsgroup_reference(rmt_nsgroup_id)
|
|
destination = local_ip_prefix or local_group
|
|
if direction == consts.OUT:
|
|
source, destination = destination, source
|
|
|
|
service = self._decide_service(sg_rule)
|
|
name = sg_rule['id']
|
|
|
|
return self.get_rule_dict(name, [source] if source else None,
|
|
[destination] if destination else None,
|
|
direction,
|
|
ip_protocol,
|
|
[service] if service else None,
|
|
action, logged)
|
|
|
|
def create_section_rules(self, section_id, nsgroup_id,
|
|
logging_enabled, action, security_group_rules,
|
|
ruleid_2_remote_nsgroup_map):
|
|
# 1. translate rules
|
|
# 2. insert in section
|
|
# 3. return the rules
|
|
firewall_rules = []
|
|
for sg_rule in security_group_rules:
|
|
remote_nsgroup_id = ruleid_2_remote_nsgroup_map[sg_rule['id']]
|
|
fw_rule = self._get_fw_rule_from_sg_rule(
|
|
sg_rule, nsgroup_id, remote_nsgroup_id,
|
|
logging_enabled, action)
|
|
|
|
firewall_rules.append(fw_rule)
|
|
return self.add_rules(firewall_rules, section_id)
|
|
|
|
def set_rule_logging(self, section_id, logging):
|
|
rules = self._process_rules_logging_for_update(
|
|
section_id, logging)
|
|
self.update(section_id, rules=rules)
|
|
|
|
def _process_rules_logging_for_update(self, section_id, logging_enabled):
|
|
rules = self.get_rules(section_id).get('results', [])
|
|
update_rules = False
|
|
for rule in rules:
|
|
if rule['logged'] != logging_enabled:
|
|
rule['logged'] = logging_enabled
|
|
update_rules = True
|
|
return rules if update_rules else None
|
|
|
|
def init_default(self, name, description, nested_groups,
|
|
log_sg_blocked_traffic):
|
|
LOG.info("Initializing the default section named %s", name)
|
|
fw_sections = self.list()
|
|
for section in reversed(fw_sections):
|
|
if section['display_name'] == name:
|
|
LOG.info("Found existing default section %s", section['id'])
|
|
break
|
|
else:
|
|
tags = self.build_v3_api_version_tag()
|
|
section = self.create_empty(
|
|
name, description, nested_groups, tags)
|
|
LOG.info("Creating a new default section %s", section['id'])
|
|
|
|
block_rule = self.get_rule_dict(
|
|
'Block All', action=consts.FW_ACTION_DROP,
|
|
logged=log_sg_blocked_traffic)
|
|
# TODO(roeyc): Add additional rules to allow IPV6 NDP.
|
|
dhcp_client = self.get_nsservice(
|
|
consts.L4_PORT_SET_NSSERVICE,
|
|
l4_protocol=consts.UDP,
|
|
source_ports=[67],
|
|
destination_ports=[68])
|
|
dhcp_client_rule_in = self.get_rule_dict(
|
|
'DHCP Reply', direction=consts.IN,
|
|
services=[dhcp_client])
|
|
|
|
dhcp_server = (
|
|
self.get_nsservice(
|
|
consts.L4_PORT_SET_NSSERVICE,
|
|
l4_protocol=consts.UDP,
|
|
source_ports=[68],
|
|
destination_ports=[67]))
|
|
dhcp_client_rule_out = self.get_rule_dict(
|
|
'DHCP Request', direction=consts.OUT,
|
|
services=[dhcp_server])
|
|
|
|
self.update(section['id'],
|
|
name, section['description'],
|
|
applied_tos=nested_groups,
|
|
rules=[dhcp_client_rule_out,
|
|
dhcp_client_rule_in,
|
|
block_rule],
|
|
force=True)
|
|
return section['id']
|
|
|
|
|
|
class NsxLibIPSet(utils.NsxLibApiBase):
|
|
|
|
@property
|
|
def uri_segment(self):
|
|
return 'ip-sets'
|
|
|
|
@property
|
|
def resource_type(self):
|
|
return 'IPSet'
|
|
|
|
def create(self, display_name, description=None, ip_addresses=None,
|
|
tags=None):
|
|
body = {
|
|
'display_name': display_name,
|
|
'description': description or '',
|
|
'ip_addresses': ip_addresses or [],
|
|
'tags': tags or []
|
|
}
|
|
return self.client.create(self.get_path(), body)
|
|
|
|
def update(self, ip_set_id, display_name=None, description=None,
|
|
ip_addresses=None, tags_update=None, update_payload_cbk=None):
|
|
# The update_payload_cbk function takes two arguments.
|
|
# The first one is the result from the internal GET request.
|
|
# The second one is a dict of user-provided attributes,
|
|
# which can be changed inside the callback function and
|
|
# used as the new payload for the following PUT request.
|
|
# For example, users want to combine the new ip_addresses
|
|
# passed to update() with the original ip_addresses retrieved
|
|
# from the internal GET request instead of overriding the
|
|
# original ip_addresses.
|
|
ip_set = {}
|
|
if tags_update:
|
|
ip_set['tags_update'] = tags_update
|
|
if display_name is not None:
|
|
ip_set['display_name'] = display_name
|
|
if description is not None:
|
|
ip_set['description'] = description
|
|
if ip_addresses is not None:
|
|
ip_set['ip_addresses'] = ip_addresses
|
|
return self._update_resource(self.get_path(ip_set_id),
|
|
ip_set, retry=True,
|
|
update_payload_cbk=update_payload_cbk)
|
|
|
|
def read(self, ip_set_id):
|
|
return self.client.get('ip-sets/%s' % ip_set_id)
|
|
|
|
def delete(self, ip_set_id):
|
|
self._delete_with_retry(ip_set_id)
|
|
|
|
def get_ipset_reference(self, ip_set_id):
|
|
return {'target_id': ip_set_id,
|
|
'target_type': consts.IP_SET}
|