zuul/zuul-jobs
Code Issues Proposed changes

tox siblings install: handle no metadata in setup.cfg

Browse Source 
Some projects have a setup.cfg included, but don't have metadata with
the package name in it.  In this case, skip on to finding it via
setup.py

Change-Id: I9339ac86832994b9f7f706c99e07441fc120b25a
This commit is contained in:
Ian Wienand 2019-05-03 10:19:54 +10:00 committed by Monty Taylor
parent 47ceef043a
commit 074967852b
1 changed files with 8 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
roles/tox/library/tox_install_sibling_packages.py
View File

@ -80,8 +80,14 @@ def get_sibling_python_packages(projects, tox_python):
found_python = True found_python = True
c = configparser.ConfigParser() c = configparser.ConfigParser()
c.read(setup_cfg) c.read(setup_cfg)
try:
package_name = c.get('metadata', 'name') package_name = c.get('metadata', 'name')
packages[package_name] = root packages[package_name] = root
except Exception:
# Some things have a setup.cfg, but don't keep
# metadata in it; fall back to setup.py below
log.append(
"[metadata] name not found in %s, skipping" % setup_cfg)
if not package_name and os.path.exists(os.path.join(root, 'setup.py')): if not package_name and os.path.exists(os.path.join(root, 'setup.py')):
found_python = True found_python = True
# It's a python package but doesn't use pbr, so we need to run # It's a python package but doesn't use pbr, so we need to run