From 38902dbba876674d95f2d3698b6fbe893649abf8 Mon Sep 17 00:00:00 2001 From: Andreas Jaeger Date: Fri, 10 Apr 2020 19:07:25 +0200 Subject: [PATCH] Fix check_jobs_documented linter If autoroles is used to document all roles - which is not the case in this repo but in opendev/base-jobs, the linter would complain about missing roles. Fix the linter to not complain. This change is here to sync the two variants and avoid others that copy it to run into the problem. Change-Id: I25411157ff18858e4f4c121a6d3f0ba6ec793be0 --- tools/check_jobs_documented.py | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/tools/check_jobs_documented.py b/tools/check_jobs_documented.py index d39c0c9e8..9e1aa94d1 100755 --- a/tools/check_jobs_documented.py +++ b/tools/check_jobs_documented.py @@ -132,10 +132,11 @@ r = Roles() d = Docs() ret = 0 -for role in r.roles: - if role not in d.roles: - print("Role %s not included in document tree" % (role,)) - ret = 1 +if not d.autoroles: + for role in r.roles: + if role not in d.roles: + print("Role %s not included in document tree" % (role,)) + ret = 1 for job in [x['name'] for x in z.layout.jobs]: if job not in d.jobs: print("Job %s not included in document tree" % (job,))