zuul/zuul-jobs
Code Issues Proposed changes

Stop running ansible-lint on playbooks

Browse Source 
The following form raises "ANSIBLE0013 Use shell only when shell
functionality is required:

  shell: '! something'

Chances are its heuristic fails to look for use of the negation (!)
shell operator.

Rather than exclude ANSIBLE0013, just stop running it completely for
now since we've had to do the same on openstack-zuul-jobs in the
I14896450b16f8e65128804b44a643da63580812d change.

Change-Id: Ie9da24a4ab20d9dd0bf7ebb2e3d957b9d8563900
Depends-On: I60daa67e7154d2bf621305e0e0aa6f4db49033c1
This commit is contained in:
Jeremy Stanley 2017-09-28 19:49:56 +00:00
parent 17034f2478
commit 4aa181a77c
1 changed files with 0 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
tox.ini
View File

@ -31,11 +31,6 @@ commands =
# Ansible Syntax Check # Ansible Syntax Check
bash -c "find playbooks -type f -regex '.*.y[a]?ml' -print0 | xargs -n1 -0 \ bash -c "find playbooks -type f -regex '.*.y[a]?ml' -print0 | xargs -n1 -0 \
ansible-playbook --syntax-check -i tests/inventory 1>/dev/null" ansible-playbook --syntax-check -i tests/inventory 1>/dev/null"
# Ansible Lint Check
# NOTE(pabelanger): Ignore the following checks:
# ANSIBlE0012: Commands should not change things if nothing needs doing
bash -c "find playbooks -type f -regex '.*.y[a]?ml' -print0 | xargs -n1 -0 \
ansible-lint -x ANSIBLE0006,ANSIBLE0012 2> /dev/null"
[testenv:venv] [testenv:venv]
commands = {posargs} commands = {posargs}