From 61228901c2a3d34492a7877513097889efe05e21 Mon Sep 17 00:00:00 2001 From: Tristan Cacqueray Date: Wed, 22 Jul 2020 13:39:21 +0000 Subject: [PATCH] dco-license: remove the empty nodeset The job was relying on a security hole to execute untrusted command on the executor (localhost). This change prevents failure after the hole is fixed. Change-Id: I910fb6e6a2659e77991111c8ce5a6b763556aeec --- playbooks/dco-license/run.yaml | 2 +- zuul.d/general-jobs.yaml | 2 -- 2 files changed, 1 insertion(+), 3 deletions(-) diff --git a/playbooks/dco-license/run.yaml b/playbooks/dco-license/run.yaml index 4f617adbd..5ba449786 100644 --- a/playbooks/dco-license/run.yaml +++ b/playbooks/dco-license/run.yaml @@ -1,4 +1,4 @@ -- hosts: localhost +- hosts: all roles: - role: validate-dco-license zuul_work_dir: "{{ zuul.executor.work_root }}/{{ zuul.project.src_dir }}" diff --git a/zuul.d/general-jobs.yaml b/zuul.d/general-jobs.yaml index f0a4a20af..d7cd3a41b 100644 --- a/zuul.d/general-jobs.yaml +++ b/zuul.d/general-jobs.yaml @@ -5,8 +5,6 @@ description: | A job to validate all new commits have been signed using --signoff. run: playbooks/dco-license/run.yaml - nodeset: - nodes: [] - job: name: unittests