From 9d8cdfaaadd39c1662df40572c724db86e746331 Mon Sep 17 00:00:00 2001 From: Ian Wienand Date: Mon, 17 Oct 2022 13:50:10 +1100 Subject: [PATCH] Fix ansible-lint name[template] ansible-lint's name[template] check looks for templates and says they should only be at the end of the string. This is because in many circumstances, including errors, the name can't be templated in -- so the message has a chance of not making sense. Honestly I can never remember when it's safe to use templates in names and not; this seems reasonable enough compromise. Change-Id: I3a415c7706494f393b126b36d7eec7193638a3f1 --- roles/copy-build-sshkey/tasks/main.yaml | 2 +- roles/ensure-openshift/tasks/main.yaml | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/roles/copy-build-sshkey/tasks/main.yaml b/roles/copy-build-sshkey/tasks/main.yaml index cdab10b24..69f911bfa 100644 --- a/roles/copy-build-sshkey/tasks/main.yaml +++ b/roles/copy-build-sshkey/tasks/main.yaml @@ -9,7 +9,7 @@ manage_dir: yes key: "{{ lookup('file', zuul_temp_ssh_key ~ '.pub') }}" - - name: Get the {{ copy_sshkey_target_user }} user home folder + - name: 'Get the user home folder for {{ copy_sshkey_target_user }}' user: name: "{{ copy_sshkey_target_user }}" register: target_user_registered diff --git a/roles/ensure-openshift/tasks/main.yaml b/roles/ensure-openshift/tasks/main.yaml index ea2b7a3eb..f74f0df8b 100644 --- a/roles/ensure-openshift/tasks/main.yaml +++ b/roles/ensure-openshift/tasks/main.yaml @@ -11,7 +11,7 @@ vars: opendev_url: https://opendev.org/zuul/zuul-jobs/src/branch/master/ -- name: "Install origin{{ origin_repo_name }} pass repository" +- name: "Install origin pass repository {{ origin_repo_name }}" become: true copy: content: |