Merge "Fix npm-run-test"

playbooks/javascript/pre-test.yaml

@@ -0,0 +1,12 @@
+- hosts: all
+  roles:
+    - role: bindep
+      bindep_profile: test
+      bindep_dir: "{{ zuul_work_dir }}"
+    - test-setup
+    - install-nodejs
+    # nodejs-test-dependencies requires sudo,
+    # so we cannot inherit pre.yaml from javascript-base.
+    - nodejs-test-dependencies
+    - revoke-sudo
+    - install-javascript-packages

roles/nodejs-test-dependencies/README.rst

@@ -0,0 +1 @@
+Install test dependencies for Node

roles/nodejs-test-dependencies/tasks/main.yaml

@@ -0,0 +1,12 @@
+- name: Install chromium-brower
+  apt:
+    name: chromium-browser
+  become: true
+
+- name: Install xvfb
+  apt:
+    name: xvfb
+  become: true
+
+- name: Run Xvfb
+  shell: "/usr/bin/Xvfb :99 -screen 0 '1280x1024x24' -ac +extension GLX +render -noreset 2>&1 > /dev/null &"

zuul.yaml

@@ -271,7 +271,6 @@
 
 - job:
     name: nodejs-npm-run-test
-    parent: javascript-base
     description: |
       Run test using nodejs.
 
@@ -282,7 +281,9 @@
 
         The version of Node to use.
 
+    pre-run: playbooks/javascript/pre-test.yaml
     run: playbooks/javascript/run-test.yaml
+    post-run: playbooks/javascript/post.yaml
 
 - job:
     name: nodejs-npm-run-lint