diff --git a/roles/add-build-sshkey/tasks/main.yaml b/roles/add-build-sshkey/tasks/main.yaml index 52a053d93..26ca1c3b7 100644 --- a/roles/add-build-sshkey/tasks/main.yaml +++ b/roles/add-build-sshkey/tasks/main.yaml @@ -8,5 +8,4 @@ - name: Create a new key in workspace based on build UUID include: create-key-and-replace.yaml - when: - - zuul_temp_ssh_key_stat.stat.exists != True + when: not zuul_temp_ssh_key_stat.stat.exists diff --git a/roles/build-releasenotes/tasks/main.yaml b/roles/build-releasenotes/tasks/main.yaml index 9396e7c0d..3e021b07b 100644 --- a/roles/build-releasenotes/tasks/main.yaml +++ b/roles/build-releasenotes/tasks/main.yaml @@ -117,7 +117,7 @@ # Remove newly created pot files rm -f ${DIRECTORY}/source/locale/*.pot - when: translations.stat.exists == True + when: translations.stat.exists - name: Run releasenotes sphinx build shell: diff --git a/roles/install-kubernetes/tasks/minikube.yaml b/roles/install-kubernetes/tasks/minikube.yaml index 425c001c8..706cc4c8b 100644 --- a/roles/install-kubernetes/tasks/minikube.yaml +++ b/roles/install-kubernetes/tasks/minikube.yaml @@ -8,7 +8,7 @@ url: https://storage.googleapis.com/minikube/releases/{{ minikube_version }}/minikube-linux-amd64 dest: /tmp/minikube mode: 0755 - when: stat_result.stat.exists == False + when: not stat_result.stat.exists - name: Run install-docker role include_role: diff --git a/tox.ini b/tox.ini index 052815c25..6d5ede496 100644 --- a/tox.ini +++ b/tox.ini @@ -44,11 +44,10 @@ commands = # [ANSIBLE0012] Commands should not change things if nothing needs doing # [204] Lines should be no longer than 160 chars # [206] Variables should have spaces before and after: {{ var_name }} - # [601] Don't compare to literal True/False bash -c "find playbooks -type f -regex '.*.ya?ml' -print0 | \ - xargs -t -n1 -0 ansible-lint -xANSIBLE0012,204,206,601" + xargs -t -n1 -0 ansible-lint -xANSIBLE0012,204,206" bash -c 'find roles -maxdepth 1 -mindepth 1 -type d -printf "%p/\n" | \ - xargs -t -n1 ansible-lint -xANSIBLE0012,204,206,601' + xargs -t -n1 ansible-lint -xANSIBLE0012,204,206' # Ansible Syntax Check bash -c "find playbooks -type f -regex '.*.ya?ml' -exec \ ansible-playbook --syntax-check -i {toxinidir}/tests/inventory \{\} + > /dev/null"