zuul/zuul-jobs
Code Issues Proposed changes

Improve ensure-tox role

Browse Source 
Avoid using ignore_errors for tasks that are likely to fail.

Change-Id: I9eae9d96a3a8ed521b3c40356f95118a5647c7c1
This commit is contained in:
Sorin Sbarnea 2020-02-19 12:53:28 +00:00
parent 9254fbb5ff
commit bab30ca2ca
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
test-playbooks/ensure-tox.yaml
View File

@ -34,11 +34,11 @@
- name: Remove tox package with pip - name: Remove tox package with pip
shell: pip uninstall -y tox shell: pip uninstall -y tox
become: true become: true
ignore_errors: true failed_when: false
- name: Remove tox package with pip3 - name: Remove tox package with pip3
shell: pip3 uninstall -y tox shell: pip3 uninstall -y tox
become: true become: true
ignore_errors: true failed_when: false
- name: Verify tox is not installed - name: Verify tox is not installed
command: "tox --version" command: "tox --version"
register: result register: result
@ -49,8 +49,8 @@
tasks: tasks:
- name: Remove tox package - name: Remove tox package
shell: pip uninstall tox || pip3 uninstall tox shell: pip uninstall tox || pip3 uninstall tox
failed_when: false
become: true become: true
ignore_errors: true
- name: Verify tox is not installed - name: Verify tox is not installed
command: "tox --version" command: "tox --version"
register: result register: result