zuul/zuul-jobs
Code Issues Proposed changes

Use become for packages in upload-puppetforge

Browse Source 
The upload-puppetforge role when executed as a
unprivileged user fails to install system packages
and the gems in the system gem home, see failure [1].

This adds become to the calls so that it becomes the
privileged user and executes these which will make them
have system access like the bindep role [2].

[1] http://logs.openstack.org/61/617ffad84b633618490ca1023f8a31d9694b31a9/release/release-openstack-puppet/c6e519d/job-output.txt.gz#_2019-01-21_20_53_17_207155
[2] https://git.openstack.org/cgit/openstack-infra/zuul-jobs/tree/roles/bindep/tasks/packages.yaml#n6

Change-Id: I4f11319727a4a5694f11abad4ded69ee554326f2
This commit is contained in:
Tobias Urdin 2019-01-21 22:14:35 +01:00
parent cb54c59577
commit db1629dc97
1 changed files with 3 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
roles/upload-puppetforge/tasks/main.yaml
View File

@ -5,6 +5,7 @@
- gcc-c++ - gcc-c++
- make - make
state: present state: present
become: yes
when: ansible_os_family == "RedHat" or ansible_os_family == "Suse" when: ansible_os_family == "RedHat" or ansible_os_family == "Suse"
- name: Install ruby dependencies on Debian based - name: Install ruby dependencies on Debian based
@ -14,6 +15,7 @@
- g++ - g++
- make - make
state: present state: present
become: yes
when: ansible_os_family == "Debian" when: ansible_os_family == "Debian"
- name: Install required gems - name: Install required gems
@ -24,6 +26,7 @@
- rake - rake
- puppetlabs_spec_helper - puppetlabs_spec_helper
- puppet-blacksmith - puppet-blacksmith
become: yes
# NOTE(tobias.urdin): The build task is needed because puppet-blacksmith # NOTE(tobias.urdin): The build task is needed because puppet-blacksmith
# doesn't provide a build task so it fails, we don't need one anyway since # doesn't provide a build task so it fails, we don't need one anyway since