d1956bd9f7
The 'linters' tox environment was not running on roles, it was only running on playbooks. This change adds a command to the linters environment to ensure all roles are linted. Since these weren't being linted, there were some problems with them. The first was a warning about usage of the shell module. Both of these usages seemed appropriate, so this patch adds a skip_ansible_lint tag to each task that was failing. The second is a warning "no action detected in task" for zuul modules. This is due to the fact that the linter cannot find the custom module. One option is to set the ANSIBLE_LIBRARY path to point to the zuul ansible library directory[1], but the linter virtualenv does not actually have zuul installed. Instead, we just disable the linter for the failing tasks. This also cleans up a comment in the tox file that was referring to a nonexistent zuul job. [1] https://github.com/willthames/ansible-review/issues/16 Change-Id: Ie49da9a09733b623bb25c5a4c8aa07eacacf4b33
13 lines
351 B
YAML
13 lines
351 B
YAML
# TODO(pabelanger): Handle cleanup on static nodes
|
|
- name: Start zuul_console daemon.
|
|
zuul_console:
|
|
tags:
|
|
# Avoid "no action detected in task" linter error
|
|
- skip_ansible_lint
|
|
|
|
- name: Synchronize src repos to workspace directory.
|
|
synchronize:
|
|
dest: "{{ zuul_workspace_root }}"
|
|
src: "{{ zuul.executor.src_root }}"
|
|
no_log: true
|