d1956bd9f7
The 'linters' tox environment was not running on roles, it was only running on playbooks. This change adds a command to the linters environment to ensure all roles are linted. Since these weren't being linted, there were some problems with them. The first was a warning about usage of the shell module. Both of these usages seemed appropriate, so this patch adds a skip_ansible_lint tag to each task that was failing. The second is a warning "no action detected in task" for zuul modules. This is due to the fact that the linter cannot find the custom module. One option is to set the ANSIBLE_LIBRARY path to point to the zuul ansible library directory[1], but the linter virtualenv does not actually have zuul installed. Instead, we just disable the linter for the failing tasks. This also cleans up a comment in the tox file that was referring to a nonexistent zuul job. [1] https://github.com/willthames/ansible-review/issues/16 Change-Id: Ie49da9a09733b623bb25c5a4c8aa07eacacf4b33
53 lines
1.7 KiB
INI
53 lines
1.7 KiB
INI
[tox]
|
|
minversion = 1.6
|
|
skipsdist = True
|
|
envlist = linters
|
|
|
|
[testenv]
|
|
basepython = python3
|
|
install_command = pip install {opts} {packages}
|
|
deps = -r{toxinidir}/test-requirements.txt
|
|
commands =
|
|
python setup.py testr --slowest --testr-args='{posargs}'
|
|
|
|
[testenv:bindep]
|
|
# Do not install any requirements. We want this to be fast and work even if
|
|
# system dependencies are missing, since it's used to tell you what system
|
|
# dependencies are missing! This also means that bindep must be installed
|
|
# separately, outside of the requirements files.
|
|
deps = bindep
|
|
commands = bindep test
|
|
|
|
[testenv:docs]
|
|
commands = python setup.py build_sphinx
|
|
|
|
[testenv:linters]
|
|
passenv =
|
|
# NOTE(pabelanger): if you'd like to run tox -elinters locally, you'll need
|
|
# to export ANSIBLE_ROLES_PATH pointing to the currect repos.
|
|
# see openstack-zuul-jobs-linters job for more information.
|
|
ANSIBLE_ROLES_PATH
|
|
whitelist_externals = bash
|
|
commands =
|
|
flake8 {posargs}
|
|
# Ansible lint
|
|
# [ANSIBLE0012] Commands should not change things if nothing needs doing
|
|
bash -c "find playbooks -type f -regex '.*.ya?ml' -print0 | \
|
|
xargs -t -n1 -0 ansible-lint -xANSIBLE0012"
|
|
bash -c 'find roles -maxdepth 1 -mindepth 1 -type d -printf "%p/\n" | \
|
|
xargs -t -n1 ansible-lint -xANSIBLE0012'
|
|
# Ansible Syntax Check
|
|
bash -c "find playbooks -type f -regex '.*.ya?ml' -exec \
|
|
ansible-playbook --syntax-check -i {toxinidir}/tests/inventory \{\} + > /dev/null"
|
|
|
|
[testenv:venv]
|
|
commands = {posargs}
|
|
|
|
[flake8]
|
|
# These are ignored intentionally in openstack-infra projects;
|
|
# please don't submit patches that solely correct them or enable them.
|
|
# E402 - ansible modules put documentation before imports. Align to ansible.
|
|
ignore = E125,E129,E402,H
|
|
show-source = True
|
|
exclude = .venv,.tox,dist,doc,build,*.egg
|