opendev/elastic-recheck
Code Issues Proposed changes

Mark non-voting jobs in the graph

Browse Source 
Commit e456a7afca added the
'allow-nonvoting' key to query yaml files so that we can
show non-voting job failures in the graph.

This change builds on that by displaying in the graph,
for non-voting job queries only based on that key, when a
job is non-voting with a simple "Voting: False" line.

Since the default behavior is to filter out non-voting
job results in all of the queries, we don't show anything
special in the graph for voting jobs since it would just
clutter up the output (non-voting is the exceptional case
we want to display).

Change-Id: Ibd75c6244abd10ad7cc491b4453339ad326a11ed
This commit is contained in:
Matt Riedemann 2016-02-15 08:46:21 -08:00
parent 4043003e69
commit 6d862c4a84
2 changed files with 7 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
elastic_recheck/cmd/graph.py
View File

@ -178,7 +178,8 @@ def main():
bug_data=bug_data, bug_data=bug_data,
fails=0, fails=0,
fails24=0, fails24=0,
data=[]) data=[],
voting=(False if query.get('allow-nonvoting') else True))
buglist.append(bug) buglist.append(bug)
try: try:
results = classifier.hits_by_query(query['query'], results = classifier.hits_by_query(query['query'],

5
web/share/gate.html
View File

@ -61,6 +61,11 @@
<h3>{{bug.fails24}} fails in 24 hrs / {{bug.fails}} fails in <h3>{{bug.fails24}} fails in 24 hrs / {{bug.fails}} fails in
10 days</h3> 10 days</h3>
<h3>Projects: {{bug.bug_data.affects}}</h3> <h3>Projects: {{bug.bug_data.affects}}</h3>
<!-- only display that a job is non-voting since voting:1 is the
default filter -->
{{#unless bug.voting}}
<h3>Voting: False</h3>
{{/unless}}
{{#if bug.bug_data.reviews}} {{#if bug.bug_data.reviews}}
<h3 class="openreviews">Open Reviews:</h3> <h3 class="openreviews">Open Reviews:</h3>
<div class="openreviews"> <div class="openreviews">