opendev/elastic-recheck
Code Issues Proposed changes

mock out lp in tests that don't really need it

Browse Source 
launchpad lib is just largely responsible for causing problems
in tests by racing on setting up directories. When we don't need
it just mock it out.

Change-Id: Ie16019b7c6e566ad55258d14f791c1f10410c4db
This commit is contained in:
Sean Dague 2014-03-10 09:52:50 -04:00
parent 2c7eb399f5
commit ce524a6c01
1 changed files with 11 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

21
elastic_recheck/tests/unit/test_bot.py
View File

@ -16,29 +16,28 @@ import ConfigParser
import unittest import unittest
import yaml import yaml
import mock
from elastic_recheck import bot from elastic_recheck import bot
# NOTE(mtreinish) Using unittest here because testtools TestCase.assertRaises # NOTE(mtreinish) Using unittest here because testtools TestCase.assertRaises
# doesn't support using it as a context manager # doesn't support using it as a context manager
class TestBot(unittest.TestCase): class TestBot(unittest.TestCase):
def setUp(self): def setUp(self):
super(TestBot, self).setUp() super(TestBot, self).setUp()
self.fake_config = ConfigParser.ConfigParser({'server_password': None}) self.fake_config = ConfigParser.ConfigParser({'server_password': None})
self._set_fake_config() self._set_fake_config()
self.channel_config = bot.ChannelConfig(yaml.load( self.channel_config = bot.ChannelConfig(yaml.load(
open('recheckwatchbot.yaml'))) open('recheckwatchbot.yaml')))
self.recheck_watch = bot.RecheckWatch(None, self.channel_config, with mock.patch('launchpadlib.launchpad.Launchpad'):
self.fake_config.get('gerrit', self.recheck_watch = bot.RecheckWatch(
'user'), None,
self.fake_config.get( self.channel_config,
'gerrit', self.fake_config.get('gerrit', 'user'),
'query_file'), self.fake_config.get('gerrit', 'query_file'),
self.fake_config.get('gerrit', self.fake_config.get('gerrit', 'host'),
'host'), self.fake_config.get('gerrit', 'key'),
self.fake_config.get('gerrit',
'key'),
False) False)
def _set_fake_config(self): def _set_fake_config(self):