openstack/cinder
Code Issues Proposed changes

Fix pylint E1101 and E1135 issue

Browse Source 
Storwize cinder driver failed in communicity CI pylint check
in last commit. This commit fixed these issues by disable
E1101 check.

Change-Id: Idfa61265e75b161b4b0080f01276401926b92727
This commit is contained in:
Xuchu Jiang 2019-11-28 10:17:24 +08:00
parent 6c2a2ff801
commit 0830eb3d90
1 changed files with 6 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
cinder/volume/drivers/ibm/storwize_svc/storwize_svc_common.py
View File

@ -488,6 +488,7 @@ class StorwizeSSH(object):
try:
return self.run_ssh_check_created(ssh_cmd)
except Exception as ex:
# pylint: disable=E1101
if hasattr(ex, 'msg') and 'CMMVC6372W' in ex.msg:
vdisk = self.lsvdisk(name)
if vdisk:
@ -1211,6 +1212,7 @@ class StorwizeHelpers(object):
multihostmap)
return int(result_lun)
except Exception as ex:
# pylint: disable=E1101
if (not multihostmap and hasattr(ex, 'msg') and
'CMMVC6071E' in ex.msg):
LOG.warning('storwize_svc_multihostmap_enabled is set '
@ -1445,6 +1447,7 @@ class StorwizeHelpers(object):
raise exception.VolumeBackendAPIException(data=ex)
else:
testValue = False
# pylint: disable=E1101
LOG.debug('Helper.'
'_wait_for_condition: %(method_name)s '
'execution failed for %(exception)s.',
@ -2123,12 +2126,13 @@ class StorwizeHelpers(object):
try:
rc_id = self.ssh.mkrcrelationship(master, aux, system,
asyncmirror, cyclingmode)
except exception.VolumeBackendAPIException as e:
except exception.VolumeBackendAPIException as ex:
rc_id = None
# CMMVC5959E is the code in Stowize storage, meaning that
# there is a relationship that already has this name on the
# master cluster.
if 'CMMVC5959E' not in e:
# pylint: disable=E1101
if hasattr(ex, 'msg') and 'CMMVC5959E' not in ex.msg:
# If there is no relation between the primary and the
# secondary back-end storage, the exception is raised.
raise