openstack/cinder
Code Issues Proposed changes

3PAR: Set the right minimum client version

Browse Source 
The 3PAR driver currently has a mismatch between the minimum version
reported in the driver-requirements.txt file and
cinder/volume/drivers/hpe/hpe_3par_common.py.

Currently the minimum version enforced by the code is 4.2.0, but that is
not correct for the iSCSI driver, since it's using the
"is_primera_array" method which was first included on 4.2.10 [1].

This patch updates the driver-requirements file to match the minimum
version for iSCSI, and also enforces version 4.2.10 for both drivers,
iSCSI and FC, for simplicity's sake.

[1]: aad5522142

Change-Id: I6698e4d6cba617413d9c53c5381ff748f64e21b4
This commit is contained in:
Gorka Eguileor 2020-05-26 16:17:49 +02:00 committed by raghavendrat
parent 94aae1b24f
commit 11034b9997
4 changed files with 3 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
cinder/tests/unit/volume/drivers/hpe/fake_hpe_3par_client.py
View File

@ -22,7 +22,7 @@ from cinder.tests.unit.volume.drivers.hpe \
import fake_hpe_client_exceptions as hpeexceptions import fake_hpe_client_exceptions as hpeexceptions
hpe3par = mock.Mock() hpe3par = mock.Mock()
hpe3par.version = "4.2.0" hpe3par.version = "4.2.10"
hpe3par.exceptions = hpeexceptions hpe3par.exceptions = hpeexceptions
sys.modules['hpe3parclient'] = hpe3par sys.modules['hpe3parclient'] = hpe3par

1
cinder/tests/unit/volume/drivers/hpe/test_hpe3par.py
View File

@ -7122,7 +7122,6 @@ class TestHPE3PARDriverBase(HPE3PARBaseDriver):
@ddt.ddt @ddt.ddt
class TestHPE3PARFCDriver(HPE3PARBaseDriver): class TestHPE3PARFCDriver(HPE3PARBaseDriver):
properties = { properties = {
'driver_volume_type': 'fibre_channel', 'driver_volume_type': 'fibre_channel',
'data': { 'data': {

2
cinder/volume/drivers/hpe/hpe_3par_common.py
View File

@ -75,7 +75,7 @@ except ImportError:
LOG = logging.getLogger(__name__) LOG = logging.getLogger(__name__)
MIN_CLIENT_VERSION = '4.2.0' MIN_CLIENT_VERSION = '4.2.10'
DEDUP_API_VERSION = 30201120 DEDUP_API_VERSION = 30201120
FLASH_CACHE_API_VERSION = 30201200 FLASH_CACHE_API_VERSION = 30201200
COMPRESSION_API_VERSION = 30301215 COMPRESSION_API_VERSION = 30301215

2
driver-requirements.txt
View File

@ -3,7 +3,7 @@
# requirements tools. # requirements tools.
# HPE 3PAR # HPE 3PAR
python-3parclient>=4.1.0 # Apache-2.0 python-3parclient>=4.2.10 # Apache-2.0
# Kaminario # Kaminario
krest>=1.3.0 # Apache-2.0 krest>=1.3.0 # Apache-2.0