openstack/cinder
Code Issues Proposed changes

NEC driver: fix an undefined variable

Browse Source 
Currently, NEC driver references an undefined variable in message
formatting.
That causes volume creation failure when 4 or more volumes are created
from same image in parallel.

This patch removes the reference.

Change-Id: I3dc6a55ee5ed496a37885a139fba11d1134e971f
Closes-Bug: #1850913
This commit is contained in:
Naoki Saito 2019-11-01 20:03:12 +09:00
parent fb0bebe788
commit 16dbad18cc
2 changed files with 8 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
cinder/tests/unit/volume/drivers/nec/test_volume.py
View File

@ -719,6 +719,13 @@ class BindLDTest(volume_helper.MStorageDSVDriver, test.TestCase):
vol, vol.size, None,
self._convert_id2name,
self._select_leastused_poolnumber)
self.mock_object(self._cli, 'get_pair_lds',
return_value={'lds1', 'lds2', 'lds3'})
with self.assertRaisesRegex(exception.VolumeBackendAPIException,
'Cannot create clone volume. '
'number of pairs reached 3. '
'ldname=LX:287RbQoP7VdwR1WsPC2fZT'):
self.create_cloned_volume(vol, src)
def test_bindld_CreateCloneWaitingInterval(self):
self.assertEqual(10, cli.get_sleep_time_for_clone(0))

3
cinder/volume/drivers/nec/volume_helper.py
View File

@ -471,8 +471,7 @@ class MStorageDriver(volume_common.MStorageVolumeCommon):
if len(pair_lds) == 3:
msg = (_('Cannot create clone volume. '
'number of pairs reached 3. '
'%(msg)s. ldname=%(ldname)s') %
{'msg': msg, 'ldname': source_name})
'ldname=%s') % source_name)
LOG.error(msg)
raise exception.VolumeBackendAPIException(data=msg)