openstack/cinder
Code Issues Proposed changes

Mock time.sleep for VMAXRestTest.test_remove_vol_from_sg_failed

Browse Source 
We don't need sleeps in unit tests. This patch makes test
ten times faster

Change-Id: Icd37566120f3ee4802240a279cf5ceca89be2dc6
This commit is contained in:
Ivan Kolodyazhny 2017-06-13 13:00:33 +03:00
parent bbf2116abe
commit 25a778cb0b
1 changed files with 3 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
cinder/tests/unit/volume/drivers/dell_emc/vmax/test_vmax.py
View File

@ -17,6 +17,7 @@ import ast
from copy import deepcopy
import datetime
import tempfile
import time
from xml.dom import minidom
import mock
@ -1218,7 +1219,8 @@ class VMAXRestTest(test.TestCase):
self.rest.wait_for_job.assert_called_with(
operation, status_code, message, self.data.extra_specs)
def test_remove_vol_from_sg_failed(self):
@mock.patch.object(time, 'sleep')
def test_remove_vol_from_sg_failed(self, mock_sleep):
device_id = [self.data.volume_details[0]['volumeId']]
self.assertRaises(
exception.VolumeBackendAPIException,