openstack/cinder
Code Issues Proposed changes

Add error reporting to generate_sample.sh on import failure.

Browse Source 
Currently tools/conf/generate_sample.sh collect options from project
modules by importing each module and looking at it's global variables
for instances of classes derived from cfg.Opt (or lists of such
instances). Sometimes this import can fail due to various reasons,
cfg.DuplicateOptError for example. And if import fails no options
from imported module written to sample config file. Error reporting
will at least warn user that some of options didn't get into sample
config.

Change-Id: I831464b1c1575c106d866a936a50ec74b2d44e59
Fixes: bug #1182611
This commit is contained in:
Anton Frolov 2013-05-31 14:27:49 +04:00
parent f30afa6e70
commit 27e261376f
1 changed files with 2 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
tools/conf/extract_opts.py
View File

@ -79,12 +79,9 @@ def _print_module(mod_str):
mod_str = mod_str[:mod_str.rfind(".")] mod_str = mod_str[:mod_str.rfind(".")]
try: try:
mod_obj = importutils.import_module(mod_str) mod_obj = importutils.import_module(mod_str)
except (ValueError, AttributeError), err:
return
except ImportError, ie:
sys.stderr.write("%s\n" % str(ie))
return
except Exception, e: except Exception, e:
sys.stderr.write("Failed to collect options from module %s: %s\n" % (
mod_str, str(e)))
return return
_list_opts(mod_obj, mod_str) _list_opts(mod_obj, mod_str)