openstack/cinder
Code Issues Proposed changes

IBM-Storage: group-create-from-src fail with error

Browse Source 
create group-create-from-src --group-snapshot fails due to wrong
parameter passed to function

Change-Id: I61430c62bda505e620f99b06ed17469ecf41e7dc
Closes-Bug: 1697414
This commit is contained in:
Isaac Beckman 2017-06-12 13:50:28 +03:00
parent 31c2328c86
commit 47b2de19ab
2 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
cinder/tests/unit/volume/drivers/ibm/test_xiv_proxy.py
View File

@ -1315,8 +1315,8 @@ class XIVProxyTest(test.TestCase):
{}, group_obj, [volume], {}, group_obj, [volume],
cgsnap_group_obj, [snapshot], None, None) cgsnap_group_obj, [snapshot], None, None)
p.ibm_storage_cli.cmd.cg_create.assert_called_once_with(cg=group_obj, p.ibm_storage_cli.cmd.cg_create.assert_called_once_with(
pool='WTF32') cg=p._cg_name_from_id(group_obj.id), pool='WTF32')
self.assertEqual('available', model_update['status']) self.assertEqual('available', model_update['status'])

2
cinder/volume/drivers/ibm/ibm_storage/xiv_proxy.py
View File

@ -1746,7 +1746,7 @@ class XIVProxy(proxy.IBMStorageProxy):
LOG.debug("Creating from cgsnapshot %(cg)s", LOG.debug("Creating from cgsnapshot %(cg)s",
{'cg': self._cg_name_from_group(cgsnapshot)}) {'cg': self._cg_name_from_group(cgsnapshot)})
try: try:
self._create_consistencygroup(context, group) self._create_consistencygroup(context, cgname)
except Exception as e: except Exception as e:
LOG.error( LOG.error(
"Creating CG from cgsnapshot failed: %(details)s", "Creating CG from cgsnapshot failed: %(details)s",